Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-tools: add netstat utiltiy #24088

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

feckert
Copy link
Member

@feckert feckert commented May 6, 2024

Maintainer: @Borromini (?)
Compile tested: x86_64, APU3 , OpenWrt latest
Run tested: x86_64, APU3, OpenWrt latest, tests done

Description:
Some user may want or need the full fuctionality of the netstat tool.

Some user may want or need the full fuctionality of the netstat tool.

Signed-off-by: Florian Eckert <fe@dev.tdt.de>
@feckert feckert merged commit a2281fe into openwrt:master May 7, 2024
13 checks passed
@feckert feckert deleted the pr/20240506-net-tools branch May 7, 2024 11:55
@BKPepe
Copy link
Member

BKPepe commented May 7, 2024

Please don't do self merging, if possible. No one reviewed it and the description is somehow vague. "Some user may want or need", ehm... thats not exactly the description. 🤷 Based on https://openwrt.org/submitting-patches, the description should explain, why it is a good idea to have the full functionality of the netstat tool. Something what you have in the description in the package.

@feckert
Copy link
Member Author

feckert commented May 7, 2024

@BKPepe
Do you or should I revert this then? Then I'll take another look at it.

@feckert
Copy link
Member Author

feckert commented May 8, 2024

@BKPepe I have reverted my changes 60a63ef and will do another pullrequest with the correct changes for a correct review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants