Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes to pass shellcheck #14996

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Minor fixes to pass shellcheck #14996

wants to merge 2 commits into from
+3 −3

Commits on Apr 3, 2024

  1. base-files: Avoid re-splitting in firstboot script 

    Before this change, the firstboot script was not
passing shellcheck test as it invoked jffs2reset
without quotes, leading to potential re-splitting.

Signed-off-by: Matteo Iervasi <matteo.iervasi@edalab.it>
    @miervasi-edalab
    miervasi-edalab committed Apr 3, 2024
    Copy the full SHA
    1353ab7 View commit details
    Browse the repository at this point in the history

  2. base-files: Fix potential issues in board_detect script 

    Before this change, the board_detect script was
parsing the output of ls to get files in /etc/board.d.
The correct method is to use globs.

Signed-off-by: Matteo Iervasi <matteo.iervasi@edalab.it>
    @miervasi-edalab
    miervasi-edalab committed Apr 3, 2024
    Copy the full SHA
    bf49979 View commit details
    Browse the repository at this point in the history