config: Enable ext4 journaling by default. #14977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehem
reviewed
Mar 27, 2024
There was a problem hiding this comment.
The patch submission system is complaining about not having anything beyond the top line. I suspect quoting part of what you've got at the top of your pull request might work for the commit message.
Yeah, this does seem like a pretty reasonable idea. I would be awfully tempted to simply purge the option and not allow creation of a non-journaled filesystem.
jordan-woyak
force-pushed
the
ext4-default-journal
branch
2 times, most recently
from
699c501
to
8536cda
Compare
Not having a journal by default is a major "gotcha". Because openwrt does not fsck on boot, a power loss without journaling can result in a dirty filesystem that openwrt will mount as read-only which requires intervention to restore the router to working order. Signed-off-by: Jordan Woyak <jordan.woyak@gmail.com>
hauke
force-pushed
the
ext4-default-journal
branch
from
8536cda
to
f9f2426
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having a journal by default is a major "gotcha".
Because openwrt does not fsck on boot, a power loss without journaling can result in a dirty filesystem that openwrt will mount as read-only which requires intervention to restore the router to working order.
I think most people would expect ext4 to have a journal and be able to handle a power loss, especially those running on desktop/server class x86 hardware.
Maybe there are some under-powered ext4-using targets that would suffer from using a journal? Someone more familiar with targets other than x86 will have to comment.
Anyways, I think a broken router from a power-loss is worse than the minor overhead of journaling.