Skip to content

Commit

Permalink
scripts/kernel_bump: Avoid potential copyright claim
Browse files Browse the repository at this point in the history 
Due to potential fears of copyright infringement noted by Elliott
Mitchell [0], rewrite our message to belong to OpenWRT.

Note, AI was used to aid in construction of this sentence.

[0]: https://lists.openwrt.org/pipermail/openwrt-devel/2024-March/042422.html

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
  • Loading branch information
@oliv3r @robimarko
oliv3r authored and robimarko committed Apr 12, 2024
1 parent ae192c0 commit 7b7f170
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/kernel_bump.sh
View file
Expand Up @@ -134,7 +134,7 @@ bump_kernel()
--signoff \
--message "kernel/${platform_name}: Create kernel files for v${target_version} (from v${source_version})" \
--message 'This is an automatically generated commit.' \
--message 'During a `git bisect` session, `git bisect --skip` is recommended.'
--message 'When doing `git bisect`, consider `git bisect --skip`.'

git checkout 'HEAD~' "${_target_dir}"
git commit \
Expand Down

4 comments on commit 7b7f170

@dangowrt
Copy link
Member

@dangowrt dangowrt commented on 7b7f170 Apr 12, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robimarko @oliv3r Can you explain this for humans please.
Edit: And please also teach your AI that OpenWrt is spelled OpenWrt and not OpenWRT.

@robimarko
Copy link
Contributor

@robimarko robimarko commented on 7b7f170 Apr 12, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, Eliott complained that messages were very similar implying a possible copyright infringement.
While I don't think these messages rise to a level of copyright infringement, this change is harmless and Elliot reviewed the PR positively.

@dangowrt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it have been easier to just give him credits if he is the original author? After all it looks like he did submit that for inclusion in a GPL-licenced project (OpenWrt), or did I get something wrong?

@robimarko
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would have to read through the whole mailing list and IRC discussions, but Oliver and Elliot each implemented tooling
for the same goal of preserving history when doing kernel updates.
Elliot in Perl and Oliver in shell, and with different approaches but in [1] Elliot complains that some messages are similar.

[1] https://lists.openwrt.org/pipermail/openwrt-devel/2024-March/042425.html

Please sign in to comment.