[testing] Added basic travis-ci tests #23
Conversation
There was a problem hiding this comment.
Great work @atb00ker 👍
I think this can be improved further before proceeding, let me know what you think.
build/openwisp_dashboard/Dockerfile
Outdated
| COPY ./openwisp_dashboard/requirements.txt /opt/openwisp/requirements.txt | ||
| RUN pip install -r requirements.txt | ||
| RUN apk add --update --no-cache --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \ |
There was a problem hiding this comment.
is it good to use http://dl-cdn.alpinelinux.org/alpine/edge/testing?
From https://wiki.alpinelinux.org/wiki/Edge
Warning: "edge" is under constant development so be careful using it in production. It is possible that bugs in "edge" could cause data loss or could break your system.
@2stacks @hispanico what do you think?
It seems to me that we should use something safer.
There was a problem hiding this comment.
Currently gdal-dev geos-dev are only available in edge, alternative would be to compile them, I was initially compiling them but that takes a lot of time and is a maintenance hassle, so for convenience I moved to this.
Let me know if compiling them sounds better. :-)
atb00ker
force-pushed
the
travis
branch
6 times, most recently
from
4fd1753
to
6461479
Compare
build/openwisp_base/Dockerfile
Outdated
| --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \ | ||
| gdal-dev geos-dev zlib-dev jpeg-dev openssl-dev libffi-dev gettext gcc && \ | ||
| apk add --update --virtual .build-deps postgresql-dev git build-base linux-headers && \ | ||
| pip install --no-cache-dir -r /opt/openwisp/requirements.txt && \ |
There was a problem hiding this comment.
I see now that you do everything in one step, are you doing it to save on image size?
I would separate the part which deal with system packages and the part which deals with the python packages
There was a problem hiding this comment.
It's done in one step because .build-deps are installed and uninstalled in the same layer to avoid taking useless files to next layer. It's a common practice I've noticed in a lot of other images as well.
The system packages not in .build-deps don't take a lot of time to install, the real thing that takes a lot of time is pip install only, hence, I coupled all of them in one layer.
Should I keep .build-deps with python packages only or move them seperately as well?
(That makes dockerfiles look cleaner but bloats the image to about twice the size.)
There was a problem hiding this comment.
how much size increase are we talking about? If it's less than 100 MB, proceed to separate them.
There was a problem hiding this comment.
After the new changes, the current size is ~450MBs and seperating will make it around ~570MBs. (However, since this is the base image, all the derived image size will be increased.)
For now, I am seperating them to different steps, since now I know what all are build dependencies, we can put them in one step without a problem in future (as per the size and build time difference in the final images.)
Let me know if your thoughts differ.
atb00ker
force-pushed
the
travis
branch
5 times, most recently
from
fb67a98
to
fe4f0a3
Compare
build/openwisp_base/Dockerfile
Outdated
| --repository http://dl-cdn.alpinelinux.org/alpine/edge/testing \ | ||
| gdal-dev geos-dev zlib-dev jpeg-dev openssl-dev libffi-dev gettext gcc && \ | ||
| apk add --update --virtual .build-deps postgresql-dev git build-base linux-headers && \ | ||
| pip install --no-cache-dir -r /opt/openwisp/requirements.txt && \ |
There was a problem hiding this comment.
how much size increase are we talking about? If it's less than 100 MB, proceed to separate them.
atb00ker
force-pushed
the
travis
branch
5 times, most recently
from
80b8eb8
to
af316de
Compare
|
@nemesisdesign Alright, Updated! 👍 |
Related: #9 #24 #29