Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logs): log errors thru stderr, with stack trace #675

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

adrienjoly
Copy link
Member

contributes to #638.

goal: make unhandled errors stand out (compared to usual logs), and easier to troubleshoot, in datadog.

@adrienjoly adrienjoly self-assigned this Aug 23, 2023
@adrienjoly adrienjoly marked this pull request as ready for review August 23, 2023 13:32
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 932b5911 42.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (932b591) Report Missing Report Missing Report Missing
Head commit (e3671c7) 5068 2954 58.29%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#675) 21 9 42.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@adrienjoly adrienjoly merged commit dbf3c96 into main Aug 23, 2023
19 checks passed
@adrienjoly adrienjoly deleted the fix/log-errors-thru-stderr-with-stack-trace branch August 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant