Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): return 404 status codes on "not found" pages #674

Merged
merged 10 commits into from
Aug 23, 2023

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Aug 23, 2023

Replaces the following log entries found in Datadog:

  • postViewer error: POST_NOT_FOUND (cf logs)
  • rendering server error page 404 for GET * (cf logs)

Contributes to #638.

@adrienjoly adrienjoly self-assigned this Aug 23, 2023
@adrienjoly adrienjoly changed the title Fix/return-404-status-codes fix(api): return 404 status codes on "not found" pages Aug 23, 2023
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (12f5b82) 5066 2986 58.94%
Head commit (b5898d2) 5116 (+50) 3010 (+24) 58.84% (-0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#674) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@adrienjoly adrienjoly marked this pull request as ready for review August 23, 2023 13:07
@adrienjoly adrienjoly merged commit f4c8867 into main Aug 23, 2023
18 checks passed
@adrienjoly adrienjoly deleted the fix/return-404-status-codes branch August 23, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant