Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): soft navigation to not rely on jquery.history #671

Merged
merged 19 commits into from
Aug 31, 2023

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Aug 20, 2023

Fixes https://github.com/openwhyd/openwhyd/security/code-scanning/15 and https://github.com/openwhyd/openwhyd/security/code-scanning/14

Contributes to #669.

Challenge

To implement Openwhyd's soft/ajax-based navigation logic (that does not interrupt the music playback when navigating), jquery.history has been used indirectly by a jQuery-based abstraction layer of window.history: jQuery History. (source code)

=> This PR rewrites that logic, using the browser's History API directly.

@adrienjoly adrienjoly self-assigned this Aug 20, 2023
@adrienjoly adrienjoly added security / privacy dependencies Pull requests that update a dependency file labels Aug 20, 2023
@adrienjoly

This comment was marked as resolved.

@adrienjoly

This comment was marked as off-topic.

@adrienjoly adrienjoly closed this Aug 28, 2023
@adrienjoly adrienjoly reopened this Aug 28, 2023
@codacy-production
Copy link

codacy-production bot commented Aug 31, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-1.87% 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4271519) 5126 3164 61.73%
Head commit (34b62a2) 5149 (+23) 3082 (-82) 59.86% (-1.87%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#671) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@adrienjoly adrienjoly marked this pull request as ready for review August 31, 2023 06:04
@adrienjoly adrienjoly changed the title fix(security): fix: remove jquery.history fix(security): soft navigation to not rely on jquery.history Aug 31, 2023
@adrienjoly adrienjoly merged commit 23afd39 into main Aug 31, 2023
19 checks passed
@adrienjoly adrienjoly deleted the fix/remove-jquery-history branch August 31, 2023 06:07
@adrienjoly
Copy link
Member Author

😌

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file security / privacy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant