fix: basic eslint warnings

openwhyd · Dec 23, 2023 · 2a38d20 · 2a38d20
1 parent bcf0f18
commit 2a38d20
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 33 deletions.
diff --git a/public/js/feed-trackorder.js b/public/js/feed-trackorder.js
@@ -21,15 +21,15 @@ const init = function () {
       success: function (res) {
         cb(res);
       },
-      error: function (e) {
+      error: function () {
         cb();
       },
     });
   }
 
   $('#playlistTrackOrderSubmit').click(function () {
     const order = [];
-    const posts = $('.post').each(function () {
+    $('.post').each(function () {
       order.push($(this).attr('data-pid'));
     });
     submitTrackOrder(plId, order, function (res) {

diff --git a/public/js/hotTracks.js b/public/js/hotTracks.js
@@ -164,20 +164,6 @@ global.timeAgoWithString = function (timestamp) {
     { 'year(s)': 12 },
   ];
 
-  const padNumber = function (str, n) {
-    let ret = '' + str;
-    while (ret.length < n) {
-      // pad with leading zeroes
-      ret = '0' + ret;
-    }
-    return ret;
-  };
-
-  const renderTime = function (t) {
-    var t = new Date(t);
-    return t.getHours() + ':' + padNumber(t.getMinutes(), 2);
-  };
-
   const renderTimestamp = function (timestamp) {
     let t = timestamp / 1000,
       lastScale = 'second(s)';
@@ -201,16 +187,6 @@ global.timeAgoWithString = function (timestamp) {
     return MONTHS_SHORT[t.getMonth()] + (sameYear ? '' : ' ' + t.getFullYear());
   };
 
-  let date = new Date(timestamp);
-  date =
-    renderTime(date) +
-    ' - ' +
-    date.getDate() +
-    ' ' +
-    MONTHS_SHORT[date.getMonth()] +
-    ' ' +
-    date.getFullYear();
-
   let ago = new Date() - timestamp;
   if (ago < 1000 * 60 * 60 * 24 * 32) {
     ago = renderTimestamp(ago);

diff --git a/public/js/playem-youtube-iframe-patch.js b/public/js/playem-youtube-iframe-patch.js
@@ -52,7 +52,7 @@ function YoutubeIframePlayer() {
     this.safeClientCall('onApiReady', this);
   }
 
-  Player.prototype.safeCall = function (fctName, param) {
+  Player.prototype.safeCall = function (fctName) {
     if (!this.iframeReady)
       return console.warn('YT-iframe not ready => ignoring call to', fctName);
     try {
@@ -137,7 +137,7 @@ function YoutubeIframePlayer() {
     }
   };
 
-  Player.prototype.getTrackPosition = function (callback) {
+  Player.prototype.getTrackPosition = function () {
     this.safeCall('getTrackPosition'); // -> will call onTrackInfo()
   };
 

diff --git a/public/js/playem-youtube-iframe.js b/public/js/playem-youtube-iframe.js
@@ -37,7 +37,7 @@ function YoutubeIframePlayer() {
     this.safeClientCall('onApiReady', this);
   }
 
-  Player.prototype.safeCall = function (fctName, param) {
+  Player.prototype.safeCall = function (fctName) {
     if (!this.iframeReady)
       return console.warn('YT-iframe not ready => ignoring call to', fctName);
     try {
@@ -117,7 +117,7 @@ function YoutubeIframePlayer() {
     this.embedVars.playerContainer.removeChild(this.iframe);
   };
 
-  Player.prototype.getTrackPosition = function (callback) {
+  Player.prototype.getTrackPosition = function () {
     this.safeCall('getTrackPosition'); // -> will call onTrackInfo()
   };
 

diff --git a/test/api/auth.api.tests.js b/test/api/auth.api.tests.js
@@ -9,7 +9,6 @@ const get = promisify(apiClient.get);
 const logout = promisify(apiClient.logout);
 const loginAs = promisify(apiClient.loginAs);
 const signupAs = promisify(apiClient.signupAs);
-const getUser = promisify(apiClient.getUser);
 
 const genSecureUser = (() => {
   let globalNumber = 0;

diff --git a/test/api/playlist.api.tests.js b/test/api/playlist.api.tests.js
@@ -2,7 +2,7 @@ const assert = require('assert');
 const util = require('util');
 const request = require('request');
 
-const { URL_PREFIX, DUMMY_USER } = require('../fixtures.js');
+const { DUMMY_USER } = require('../fixtures.js');
 const { ObjectId } = require('../approval-tests-helpers.js');
 const api = require('../api-client.js');
 const { OpenwhydTestEnv } = require('../OpenwhydTestEnv.js');

diff --git a/test/approval/routes/routes.approval.tests.js b/test/approval/routes/routes.approval.tests.js
@@ -39,7 +39,7 @@ test.before(async (t) => {
     testDataCollections.user.find(({ _id }) => id === _id.toString());
 });
 
-test.after(async (t) => {
+test.after(async () => {
   if (!DONT_KILL) await openwhyd.release();
 });