Add a "Show Correct Answers" button to the problem and test pages. #2406
Conversation
|
I think this is nice for all correct answers. Here was a problem I was looking at: 
and I roughly cut the padding in half on the answers a bit to get: 
Needs a bit of work, but might be nice to have answers that are 1 line high to be similar in height to the buttons so there is less overlap. (I know this won't work with all problems.) |
|
Cutting the padding barely helps. Generally speaking there is a problem authoring issue here. Even without the feedback shown you can see in your screen shots that the inputs are smashed together from one line to the next. That does not look good, and a problem author should do a better job of insuring spacing between lines. Bad problem authoring practices that make problems not look good in general is a large part of the issue with the feedback popovers overlapping to begin with. |
drgrice1
force-pushed
the
show-correct-answers-button
branch
2 times, most recently
from
ac0b7da
to
d77064e
Compare
|
I reduced the padding on the popover in the special case that correct answers are the only thing shown. It helps a little with problems that smash things together. But doesn't help the generally poor appearance of those problems to begin with, and doesn't help if the answers themselves have more height or the case of tightly grouped answers on the same line. |
drgrice1
force-pushed
the
show-correct-answers-button
branch
from
d77064e
to
5fa4a8c
Compare
|
Those conflicts you predicted are here now. |
drgrice1
force-pushed
the
show-correct-answers-button
branch
from
5fa4a8c
to
9078c81
Compare
drgrice1
force-pushed
the
show-correct-answers-button
branch
from
9078c81
to
6d93bb8
Compare
When this button is used correct answers will be shown with no other content in the feedback popover, scaffolds will all be open, and the feedback popovers will open immediately on page load. This is an instructor only option for now. I don't think this will be a good idea to enable for students. Furthermore, the "Show Correct Answers" buttons on other instructor pages (pg problem editor, problem library, set detail page, statistics, and manual problem grader) now use this for showing correct answers. This works well for most problems, but there are some cases where answers are tightly grouped particularly when there are on the same line that the popovers can overlap in not the best way. This is one potential resolution of openwebwork/pg#1047.
drgrice1
force-pushed
the
show-correct-answers-button
branch
from
6d93bb8
to
38a5055
Compare
When this button is used correct answers will be shown with no other content in the feedback popover, scaffolds will all be open, and the feedback popovers will open immediately on page load. This is an instructor only option for now. I don't think this will be a good idea to enable for students.
Furthermore, the "Show Correct Answers" buttons on other instructor pages (pg problem editor, problem library, set detail page, statistics, and manual problem grader) now use this for showing correct answers.
This works well for most problems, but there are some cases where answers are tightly grouped particularly when there are on the same line that the popovers can overlap in not the best way.
This is one potential resolution of openwebwork/pg#1047.
Note that this requires openwebwork/pg#1065 to work.
Also, this is built on top of #2395, and will have conflicts with #2405 that will need to be resolved.