Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return w3c for anoncreds #1842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TimoGlastra
Copy link
Contributor

No description provided.

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a super-elegant fix! But I'm not sure if it will work, since the credentialRecordId of the created W3CCredentialRecord seems to be different from the previous one. Am I right?

@TimoGlastra
Copy link
Contributor Author

Hmm but in that case we also aren't able to determine the id in the migration script for 0.6? As there's not link anymore between the W3C record and the old record?

@TimoGlastra
Copy link
Contributor Author

But you're right, good catch @genaris. The ID is different

@TimoGlastra
Copy link
Contributor Author

Not sure how to fix this... I think we shouldn't hold up the 0.5.2 release for it but good to properly fix. I'm going to think about it in more detail

@genaris
Copy link
Contributor

genaris commented Apr 26, 2024

Hmm but in that case we also aren't able to determine the id in the migration script for 0.6? As there's not link anymore between the W3C record and the old record?

Yes, unfortunately at the moment I don't see any straightforward upgrade path for those who are already using 0.5.1. In our case we got the relationship by using the issuance date, since we were storing some info within the record metadata, but I don't know if there is some other way to link both records once the anoncreds one is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants