build-info: add Cygwin version information #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solardiz
requested changes
Mar 31, 2024
src/listconf.c
Outdated
|
|
||
| errno = 0; | ||
| if (uname(&buffer) != 0) | ||
| printf("Cygwin version detection error"); |
There was a problem hiding this comment.
Add \n or use puts.
Also, why reset errno if we don't check it later? Even if we did use errno, per POSIX it should be safe to do so after uname returns failure - but success is indicated by a non-negative value, not just 0. Perhaps Cygwin has its own documentation making this more specific.
POSIX:
RETURN VALUE
Upon successful completion, a non-negative value shall be returned.
Otherwise, -1 shall be returned and errno set to indicate the error.
claudioandre-br
force-pushed
the
listconf
branch
2 times, most recently
from
301ee7f
to
b9c2830
Compare
The recent version of Cygwin removed support for many old Windows versions/platforms. Adding this information to the output can help us detect if end users are complaining about unsupported things. Signed-off-by: Claudio André <dev@claudioandre.slmail.me>
claudioandre-br
force-pushed
the
listconf
branch
from
b9c2830
to
cd9b8cb
Compare
solardiz
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent version of Cygwin removed support for many old Windows versions/platforms. Adding this information to the output can help us detect if end users are complaining about unsupported things.