Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align timing routines, fix average inference calculation #2162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Align timing routines, fix average inference calculation #2162

wants to merge 1 commit into from

Conversation

ngaloppo
Copy link
Contributor

The callback function records inference time based on the timestamp sent by the client using self.get_timestamp(). The display() function needs to use the same timing routine to get consistent time deltas.

@ngaloppo
Copy link
Contributor Author

@dtrawins FYI

rasapala
rasapala approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@rasapala rasapala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaloppo
Copy link
Contributor Author

@dtrawins can you merge?

@atobiszei atobiszei added the contribution External contribution label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasapala rasapala rasapala approved these changes

@dtrawins dtrawins Awaiting requested review from dtrawins

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
contribution External contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngaloppo @rasapala @atobiszei