Stop viewer new schedules #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-breaking change (adds args to getFormattedStopTime signature)
|
One quick comment: for the scrolling, I think we should perhaps have the controls at the top of the stop viewer fixed in place (rather than disappearing when I scroll down the list of arrivals). The table headers should also stay fixed if possible. |
This prevents overlap of the header content with the scrolling content (e.g. long route lists or long schedules).
landonreed
requested changes
Dec 16, 2020
|
Ready to review again, hopefully. |
landonreed
reviewed
Dec 17, 2020
landonreed
reviewed
Dec 17, 2020
|
Ready to review once more. |
evansiroky
approved these changes
Jan 27, 2021
landonreed
reviewed
Jan 28, 2021
| # # not begin service again until Monday, we are showing its next | ||
| # # departure and it is not entirely excluded from display | ||
| # # (defaults to 4 days/345600s if unspecified). | ||
| # timeRange: 345600 |
There was a problem hiding this comment.
Thanks for adding all of this!
landonreed
reviewed
Jan 28, 2021
lib/reducers/create-otp-reducer.js
Outdated
| @@ -74,6 +74,8 @@ export function getInitialState (userDefinedConfig, initialQuery) { | |||
| routingTypes: [], | |||
| stopViewer: { | |||
| numberOfDepartures: 3, // per pattern | |||
| // Hide block ids unless explicitly enabld in config. | |||
There was a problem hiding this comment.
Oh, the spellchecker did not catch that @evansiroky!?
landonreed
approved these changes
Jan 28, 2021
binh-dam-ibigroup
added
BLOCKED
Merged
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #286 and fixes #287 as follows:
StopScheduleTablesorted by departures across all patterns.(it will be underneath the stop viewer header)and highlights it./date/OTP endpoint, removing stop times previously included from the previous service day.stoptime.headsignreturned by OTP are blank, they are populated using the pattern description from OTP.utils/viewer.js, including a newStopTimeCellcomponent used byPatternRowRemaining issues
working on this nextrefactored in c7e2368.PatternRow, will get removed eventiually. => Removed.