Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracker/nn: Add support for 3x3 pos/size cov matrix (and some cleanup) #1845

Conversation

DaWelter
Copy link
Contributor

@DaWelter DaWelter commented May 9, 2024

This PRs main purpose is to add support for 3x3 covariance matrices for position+size estimation.
My recent (unreleased) models output those instead of only component wise standard deviations.

Overall

  • Accept 3x3 covariance matrix output for position+size
  • Old models still worked fine in my testing
  • Delete commented code which was there previously to support recurrent models. (Won't be used in foreseeable future)
  • Delete leftover code for experiments with closed eyes detection (Likewise, I have given up on that / Is not really needed any more)
  • Improve comments and code quality in the internal filter code

@DaWelter DaWelter requested a review from sthalik May 9, 2024 11:27
Copy link
Member

@sthalik sthalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sthalik
Copy link
Member

sthalik commented May 9, 2024

As far as the unitialized metadata version field is concerned, could you add a custom metadata field to new models? Then the value would signify that the metadata isn't left uninitialized.

@DaWelter
Copy link
Contributor Author

DaWelter commented May 9, 2024

As far as the unitialized metadata version field is concerned, could you add a custom metadata field to new models? Then the value would signify that the metadata isn't left uninitialized.

Good idea. I could try this next time.

@DaWelter DaWelter merged commit ce7a187 into opentrack:master May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants