New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to use user specified versions of wine. #1571
base: master
Are you sure you want to change the base?
Conversation
@@ -27,6 +27,7 @@ struct settings : opts | |||
value<int> proton_appid{b, "proton-appid", 0}; | |||
value<QVariant> proton_path{b, "proton-version", {} }; | |||
value<QString> wineprefix{b, "wineprefix", "~/.wine"}; | |||
value<QString> wine_exec_location{b, "wine_exec_location", "wine"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use hyphens to separate words for .ini strings.
@@ -27,6 +27,7 @@ struct settings : opts | |||
value<int> proton_appid{b, "proton-appid", 0}; | |||
value<QVariant> proton_path{b, "proton-version", {} }; | |||
value<QString> wineprefix{b, "wineprefix", "~/.wine"}; | |||
value<QString> wine_exec_location{b, "wine_exec_location", "wine"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value<QString> wine_exec_location{b, "wine_exec_location", "wine"}; | |
value<QString> wine_exec_location{b, "wine-exec-location", "wine"}; |
@@ -33,16 +33,16 @@ | |||
<string>Wine variant</string> | |||
</property> | |||
<layout class="QGridLayout" name="gridLayout"> | |||
<item row="0" column="0"> | |||
<widget class="QRadioButton" name="variant_wine"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do that.
<property name="sizePolicy"> | ||
<sizepolicy hsizetype="Minimum" vsizetype="Preferred"> | ||
<horstretch>0</horstretch> | ||
<verstretch>0</verstretch> | ||
</sizepolicy> | ||
</property> | ||
<property name="text"> | ||
<string>Wine (system)</string> | ||
<string>Proton (Steam Play)</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do that either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
I've added the ability for a user to point to their own wine executable. This will allow users who wish or are required to use custom wine distributions on non-steam games the ability to do so. The UI isn't neat currently as I've no prior experience with QT.