Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Matrix.Equals() with simd implementation (OTK4) #1722

Closed

Conversation

BoyBaykiller
Copy link
Contributor

This PR ports #1721 to OpenTK4.
Interestingly I needed to add [MethodImpl(MethodImplOptions.AggressiveInlining)] for there to be any significant performance improvement.

@BoyBaykiller
Copy link
Contributor Author

I've personally switched to OTK5 and don't need this anymore. The SIMD implementation in OTK5 is also much cleaner.
I would be fine with closing this PR if you don't think it's worth it in general.

@NogginBops
Copy link
Member

Sorry for not getting to these PRs faster.
As you say, the implementation here is quite messy compared to the OTK5 one, so it's probably easiest to just get that PR in and close this one.
Unless we have more people interested in faster matrix equality checks for OTK4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants