[avahi] conditionalize Avahi Service Start and Installation (#2280) #2282
Conversation
kevinanderson1
force-pushed
the
conditional_avahi
branch
2 times, most recently
from
e0f8e40
to
7c1f16c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2282 +/- ##
===========================================
- Coverage 55.77% 39.77% -16.01%
===========================================
Files 87 88 +1
Lines 6890 9778 +2888
Branches 0 721 +721
===========================================
+ Hits 3843 3889 +46
- Misses 3047 5691 +2644
- Partials 0 198 +198 ☔ View full report in Codecov by Sentry. |
The CI tests run in this PR. You will need to pass those failing tests.
|
kevinanderson1
force-pushed
the
conditional_avahi
branch
3 times, most recently
from
3770df1
to
a6a0e65
Compare
kevinanderson1
force-pushed
the
conditional_avahi
branch
3 times, most recently
from
7320446
to
da557fd
Compare
|
@superwhd I believe this is ready for review. |
script/bootstrap
Outdated
|
|
||
| # Thread Certification tests require Avahi to publish records for tests. Since the | ||
| # same image is used for all tests this needs to be installed here. | ||
| if [[ ${OTBR_MDNS} == "avahi" || ${OT_BACKBONE_CI} == 1 ]]; then |
There was a problem hiding this comment.
@sunytt Do you think ${OT_BACKBONE_CI} == 1 will be true when building a BR reference release? Is there a more accurate variable?
There was a problem hiding this comment.
When building reference release the bootstrap script is called with the build option REFERENCE_DEVICE=1, when the reference device is a BR it also has the build option BORDER_ROUTING=1.
Can we use the combination of those 2 build options here?
There was a problem hiding this comment.
I've modified the PR to ensure Avahi is installed if REFERENCE_DEVICE=1.
|
LGTM overall except concern of failing to include avahi in BR reference release. |
kevinanderson1
force-pushed
the
conditional_avahi
branch
from
da557fd
to
d3506ae
Compare
Ensure the Avahi daemon is installed and started only when OTBR_MDNS == "avahi". This prevents multiple mDNS stacks from running especially in container environments.
kevinanderson1
force-pushed
the
conditional_avahi
branch
from
d3506ae
to
1fb1360
Compare
|
@superwhd I've modified the PR to ensure Avahi is installed if |
jwhui
changed the title
Ensure the Avahi daemon is installed and started only when OTBR_MDNS == "avahi". This prevents multiple mDNS stacks from running especially in container environments.
I saw in the CONTRIBUTING documentation that CI checks should pass but I'm not sure how to get them to run in my fork.
Fixes #2280