Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[border-agent] add _meshcop-e service for ePSKc mode #2259

Merged
merged 1 commit into from May 16, 2024

Conversation

mia1yang
Copy link
Contributor

@mia1yang mia1yang commented Apr 22, 2024

Meshcop-e service is published when receiving DNS query for PTR records and BA is in the "ba ephemeralkey" active mode with the same instance name with Meshcop service and different UDP port number for the DTLS connection using ePSKc.
Test:

  1. Active ePSKc mode using "ba ephemeralkey" commands, verified Meshcop-e package and service
  2. DTLS connection could successfully set using ePSKc mode with Candidate Commissioner.
  3. DTLS connection using ePSKc by inputing wrong ePSK in Candidate Commissioner, Meshcop-e service has been unpublished and no negative impacted with Meshcop service.
  4. Meshcop-e service unpublished after timeout.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 4.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 39.77%. Comparing base (2b41187) to head (755264c).
Report is 656 commits behind head on main.

Files Patch % Lines
src/border_agent/border_agent.cpp 4.00% 24 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2259       +/-   ##
===========================================
- Coverage   55.77%   39.77%   -16.01%     
===========================================
  Files          87       88        +1     
  Lines        6890     9778     +2888     
  Branches        0      721      +721     
===========================================
+ Hits         3843     3889       +46     
- Misses       3047     5691     +2644     
- Partials        0      198      +198     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

src/border_agent/border_agent.cpp Show resolved Hide resolved
@mia1yang mia1yang force-pushed the epskc-e branch 2 times, most recently from d8cafe7 to 16ee543 Compare April 22, 2024 04:01
@mia1yang mia1yang force-pushed the epskc-e branch 5 times, most recently from 3a5ee5b to e53079c Compare April 22, 2024 04:26
src/border_agent/border_agent.cpp Outdated Show resolved Hide resolved
src/border_agent/border_agent.cpp Show resolved Hide resolved
src/border_agent/border_agent.cpp Outdated Show resolved Hide resolved
src/border_agent/border_agent.cpp Outdated Show resolved Hide resolved
src/border_agent/border_agent.cpp Outdated Show resolved Hide resolved
@mia1yang mia1yang force-pushed the epskc-e branch 7 times, most recently from 9b8220f to 1336fbe Compare May 11, 2024 07:21
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mia1yang mia1yang force-pushed the epskc-e branch 3 times, most recently from e67e3dc to df670b1 Compare May 13, 2024 16:34
Copy link
Member

@abtink abtink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jwhui jwhui changed the title [border agent] add Meshcop-e service for ePSKc mode [border-agent] add _meshcop-e service for ePSKc mode May 16, 2024
@jwhui jwhui merged commit 4b545bc into openthread:main May 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants