[web] show pskc on the "status" web page #2249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Displaying PSKC on a web page is more convenient for users to obtain value as a credential for the commissioner to join the network.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
===========================================
- Coverage 55.77% 39.81% -15.97%
===========================================
Files 87 88 +1
Lines 6890 9746 +2856
Branches 0 718 +718
===========================================
+ Hits 3843 3880 +37
- Misses 3047 5668 +2621
- Partials 0 198 +198 ☔ View full report in Codecov by Sentry. |
wgtdkp
approved these changes
Apr 15, 2024
|
jwhui
reviewed
Apr 26, 2024
| @@ -383,6 +383,9 @@ std::string WpanService::HandleStatusRequest() | |||
| VerifyOrExit((rval = client.Execute("partitionid")) != nullptr, ret = kWpanStatus_GetPropertyFailed); | |||
| networkInfo["Network:PartitionID"] = rval; | |||
|
|
|||
| VerifyOrExit((rval = client.Execute("pskc")) != nullptr, ret = kWpanStatus_GetPropertyFailed); | |||
| networkInfo["Network:PSKc"] = rval; | |||
There was a problem hiding this comment.
We should not encourage directly displaying a static credential that can be used to administer the network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying PSKC on a web page is more convenient for users to obtain value as a credential for the commissioner to join the network.