[srpl] integrate SRPL #1743
Open
[srpl] integrate SRPL #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superwhd
force-pushed
the
srpl-github-pr
branch
3 times, most recently
from
953800a
to
5eccff2
Compare
superwhd
force-pushed
the
srpl-github-pr
branch
2 times, most recently
from
f286297
to
853238d
Compare
superwhd
commented
Feb 10, 2023
superwhd
force-pushed
the
srpl-github-pr
branch
from
853238d
to
94fa8de
Compare
wgtdkp
reviewed
Feb 14, 2023
superwhd
force-pushed
the
srpl-github-pr
branch
from
94fa8de
to
312a353
Compare
wgtdkp
reviewed
Feb 17, 2023
bukepo
reviewed
Feb 22, 2023
superwhd
force-pushed
the
srpl-github-pr
branch
8 times, most recently
from
1bc6caf
to
0f2d158
Compare
wgtdkp
reviewed
Feb 28, 2023
superwhd
force-pushed
the
srpl-github-pr
branch
2 times, most recently
from
5f323b2
to
719eafc
Compare
abtink
approved these changes
Mar 8, 2023
| partnerInfo.mTxtLength = aInstanceInfo.mTxtData.size(); | ||
| partnerInfo.mSockAddr.mPort = aInstanceInfo.mPort; | ||
| } | ||
| otPlatSrplHandleDnssdBrowseResult(mNcp.GetInstance(), &partnerInfo); |
There was a problem hiding this comment.
We have this requirement from platform API:
If the IPv6 address of the an already discovered/added service changes, then the platform MUST first call
otPlatSrplHandleDnssdBrowseResult()to remove the old address, before calling it again to add the new
address.
Will this work?
There was a problem hiding this comment.
I added the logic to support this. Note that currently only 1 address is returned in a callback. When a service with N addresses is discovered, it triggers N add events and N - 1 remove events which results in unnecessary operations. It doesn't break my test though. I'll work on supporting multiple addresses later.
superwhd
force-pushed
the
srpl-github-pr
branch
from
719eafc
to
d8ad775
Compare
superwhd
force-pushed
the
srpl-github-pr
branch
from
d8ad775
to
d3d5656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the platform code for supporting SRPL. It depends on the openthread PR openthread/openthread#8403.
This PR also contains the commit of #1742. Please review the most recent commit only.
Future work:
Test: