Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unified command processing capability #1017

Merged
merged 2 commits into from May 16, 2022
Merged

chore: unified command processing capability #1017

merged 2 commits into from May 16, 2022

Conversation

dqhl76
Copy link
Contributor

@dqhl76 dqhl76 commented May 12, 2022

Types

  • 🧹 Chores

Background or solution

close #980

Changelog

将commander改为yargs

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1017 (6d3323b) into main (c681e8d) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   58.50%   58.75%   +0.24%     
==========================================
  Files        1225     1225              
  Lines       75546    75545       -1     
  Branches    15705    15709       +4     
==========================================
+ Hits        44201    44386     +185     
+ Misses      28572    28398     -174     
+ Partials     2773     2761      -12     
Flag Coverage Δ
jsdom 53.31% <ø> (+3.92%) ⬆️
node 16.05% <ø> (-9.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/theme/src/browser/icon.service.ts 83.90% <0.00%> (-0.68%) ⬇️
...es/src/browser/userstorage/user-storage.service.ts 56.81% <0.00%> (-0.49%) ⬇️
packages/file-service/src/common/files.ts 86.84% <0.00%> (-0.34%) ⬇️
...xtension/src/browser/vscode/api/main.thread.doc.ts 62.02% <0.00%> (-0.24%) ⬇️
packages/keymaps/src/browser/keymaps.service.ts 60.85% <0.00%> (-0.11%) ⬇️
...c/browser/abstract-resource-preference-provider.ts 83.13% <0.00%> (-0.10%) ⬇️
packages/extension/src/common/vscode/ext-types.ts 50.40% <0.00%> (-0.08%) ⬇️
packages/core-common/src/network.ts 100.00% <0.00%> (ø)
packages/file-scheme/src/common/index.ts 100.00% <0.00%> (ø)
packages/electron-basic/src/browser/index.ts 73.46% <0.00%> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c681e8d...6d3323b. Read the comment docs.

@dqhl76 dqhl76 changed the title chore: unified command processing capability WIP: unified command processing capability May 13, 2022
@dqhl76
Copy link
Contributor Author

dqhl76 commented May 13, 2022

更换为yargs之后尝试用webpack打包时遇到了如下的报错
image
发现似乎和Webpack building broken #1754有关,正在尝试解决

@Aaaaash
Copy link
Member

Aaaaash commented May 13, 2022

更换为yargs之后尝试用webpack打包时遇到了如下的报错 image 发现似乎和Webpack building broken #1754有关,正在尝试解决

参考一下这个 PR 吧 https://github.com/opensumi/core/pull/142/files

@dqhl76 dqhl76 changed the title WIP: unified command processing capability chore: unified command processing capability May 13, 2022
@dqhl76
Copy link
Contributor Author

dqhl76 commented May 13, 2022

iShot_2022-05-13_16.37.25.mp4

@erha19 erha19 merged commit 692de31 into opensumi:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] 统一命令处理能力(yargs)
3 participants