OpenID connect icon to SVG #4795
Conversation
|
54cde47 - I thought the maintainers here like clean commit history... |
There was a problem hiding this comment.
From CONTRIBUTING.md
- Avoid including "fixup" commits. If you have added a fixup commit (for example to fix a rubocop warning, or because you changed your own new code) please combine the fixup commit into the commit that introduced the problem. git rebase -i is very useful for this.
- Avoid including "merge" commits. If your PR can no longer be merged cleanly (for example, an unrelated change to Gemfile.lock on master now conflicts with your PR) then please rebase your PR onto the latest master. This allows you to fix the conflicts, while keeping the PR a straightforward list of commits. If there are no conflicts, then there is no need to rebase anything.
I know @tomhughes has fixed other pull requests already, but if you can fix these problems yourself before we review your PRs, then it makes it easier for everyone.
hiddewie
force-pushed
the
retina-svg-openid
branch
from
54cde47
to
c7c665d
Compare
Sorry, I missed this part in the contributing guidelines. I am used to the Github feature to squash PRs into a single commit into the default branch, which uses the PR title and description as resulting commit. I will squash my commits into a single commits from now on. |
re-add whitespace trigger CI revert size attribute
hiddewie
force-pushed
the
retina-svg-openid
branch
from
c7c665d
to
036c87b
Compare
No problem, thanks for making the changes
If it's worth having multiple commits, then please keep using multiple commits! No need to squash unnecessarily. You'll see from many of the other PRs (e.g. https://github.com/openstreetmap/openstreetmap-website/pull/4680/commits) that we use multiple commits in order to do things like allow better |
Part of #850
Split off from #4775
This pull request replaces PNG icons for the OpenID icons with their minimized SVG variants, to ensure screens with high pixel densities can display the OpenStreetMap website with beautiful graphics.
Tested on http://127.0.0.1:3000/login