Replace sign up, terms and confirmation illustrations with SVG #4793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddewie
changed the title
|
I think the original svgs need to be preserved somewhere outside of the directory that's being served. If the images are to be edited later, you'll want to edit the originals that contain text strings with font definitions and whatever else there is to be used by the editor. |
👍 From #4799 (comment): I will move the source files into a separate |
remove app/assets/images/confirm-illustration.png confirm illustration align illustrations minimize illustrations Add original design files in assets
hiddewie
force-pushed
the
retina-svg-terms-signup
branch
from
3288752
to
4aef6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #850
Split off from #4775
This pull request replaces PNG images for the signup and terms illustrations with their minimized SVG variants, to ensure screens with high pixel densities can display the OpenStreetMap website with beautiful graphics.
TODO: the confirm illustration (from #4775 (comment))The illustrations have all been resized to the same size and aligned on one corner.
Sign up page (http://127.0.0.1:3000/user/new):
Confirmation page (http://127.0.0.1:3000/user/iertn/confirm):
Terms page (http://127.0.0.1:3000/user/terms)