Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have two columns for layer buttons between small and medium screen widths #4760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Contributor

Originally I wanted smaller buttons but that's not easy to do if I'm not allowed to check their widths. Then let's at least not have overly wide buttons when the screen is about 700px wide.

Before:
image

After:
image

@tomhughes
Copy link
Member

Looking at this in responsive view and gradually reducing the size I don't really like the way it switches from one column to two and then back to one.

That's not how real users will use it though - they'll most just have a device and see whatever view that device's size gives them. Well at least unless they use a desktop browser and make the window small enough to not get the large view which would be kind of wierd.

So my next question was, what sort of devices exactly get this view, and the answer initially seems to be "not many" as tablets are too large to get it and even large phones are too small to get it.

What does trigger it of course is a phone in landscape mode, and then it kind of makes sense because you have lots of width for the two columns, but not much height if you want to avoid scrolling.

Was that the use case you had in mind for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants