Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout on show note pages #4647

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Contributor

Also disables timeout on index pages that show user's notes because:

  • note timeouts never worked correctly
  • no working non-map layout timeouts were implemented on the website

I might add index timeout later, but that wouldn't be fixing things, that would be implementing something new.

Taken out of #4617 to keep that PR about fixing things that used to work.

@tomhughes
Copy link
Member

tomhughes commented May 21, 2024

I might add index timeout later, but that wouldn't be fixing things, that would be implementing something new.

I don't follow the logic here... You're adding :only so previously there would have been a timeout around the index action surely? It might not have rendered a nice error when it triggered but it would have protected the server from locking up a daemon for a long time while it processed the action surely which is the most important thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants