Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bicycle_road presets with special access field #1207

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Apr 29, 2024

Ping #1013

  • Add presets for cycleway and residential as searchable presets
  • Add presets for other common highway classes path and service unsearchable
  • Add searchable presets to a category
  • Add a new restriction field to work around the fact that the access-field does not support the vehicle case – See todos.

--

This is a draft for now until I had time to test it in the preview.

--

Other todos

Copy link

🍱 You can preview the tagging presets of this pull request here.

@@ -0,0 +1,23 @@
{
"key": "vehicle",
"type": "defaultCheck",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tordans
Copy link
Collaborator Author

tordans commented Apr 29, 2024

Documentation Test 1

This is the version with a special vehicle checkbox field.

Road type Part1 Part2
cycleway Bildschirmfoto 2024-04-29 um 21 45 07 Bildschirmfoto 2024-04-29 um 21 45 16
residential Bildschirmfoto 2024-04-29 um 21 45 26 Bildschirmfoto 2024-04-29 um 21 45 22

This requires to remove the "copy fields from parent" in order to remove the original `access` field
@tordans
Copy link
Collaborator Author

tordans commented Apr 30, 2024

Documenting Test 2

This is the version with a copy of the access field. This version requires to duplicate the fields from the parent preset in order to get rid of the original access field. But that is OK IMO.

I still don't like how hidden the difference between vehicle and motor_vehicle is in that access field table. But that is nothing we can fix here but for #1208 or the GSOC project.

I consider this Test 2 a much better result than Test 1.

@tordans
Copy link
Collaborator Author

tordans commented May 7, 2024

Testing

There is a bug when changing an existing way to one of those presets. It looks like the highway tags get removed so the style and preset break. – Need to create a propper test case.

@tordans
Copy link
Collaborator Author

tordans commented May 7, 2024

Testing

Need to look into making this preset country specific, so moving cyclestreet-BE-NL to the preset level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant