Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway #1193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

balchen
Copy link

@balchen balchen commented Apr 6, 2024

Do not enforce Cycle & Foot Path or Cycle & Foot Crossing in Norway (NO) due to the NO community not applying bicycle=designated on highway=cycleway. See https://wiki.openstreetmap.org/wiki/No:Map_Features#Sykkel for reference.

Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.

…NO) due to the NO community not applying bicycle=designated on highway=cycleway

Also fix an apparent bug in that DE is excluded from Cycle & Foot Path, but not from Cycle & Foot Crossing.
@tordans
Copy link
Collaborator

tordans commented Apr 7, 2024

FYI we discussed an update path to the current crossing presets during the last iD community meetup. This hat not been properly documented nor implemented, though. I think we should first work on this cleanup before adding more complexity on top of it.

@balchen
Copy link
Author

balchen commented Apr 7, 2024

FYI we discussed an update path to the current crossing presets during the last iD community meetup. This hat not been properly documented nor implemented, though. I think we should first work on this cleanup before adding more complexity on top of it.

I'm sorry, I'm not sufficiently involved in the iD community to understand what you wrote.

However, the change I'm proposing doesn't appear to add any complexity. I'm just adding another country to an existing list of countries. Could you explain the added complexity?

@balchen
Copy link
Author

balchen commented Apr 13, 2024

It's a relatively straight-forward change, so I imagine the review will be quick and simple. I don't know the process to move this forward. Is there something that needs to be done?

@@ -4,8 +4,10 @@
"fr",
"lt",
"pl",
"de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I created #1204 to improve this situation

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Does that mean there's progress on this PR as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants