Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_emergency.json: Added check_date to fields #1184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpds
Copy link

@jpds jpds commented Mar 29, 2024

This is used by consumers such as OpenAEDMap.

Copy link

github-actions bot commented Apr 5, 2024

🍱 You can preview the tagging presets of this pull request here.

@tyrasd
Copy link
Member

tyrasd commented Apr 5, 2024

The check_date field has the "universal": true flag, and is therefore already available for all presets. This change would only affect AED features which do not have this tag already (then the universal field is "hidden" under "more fields"). Was is the intent of this PR to make it visible also if unset?

I'm just wondering why this preset should be handled differently compared to other features, like other emergency infrastructure like fire hydrants for example.

@jpds
Copy link
Author

jpds commented Apr 6, 2024

Was is the intent of this PR to make it visible also if unset?

Yes, I hadn't thought about the other emergency things - do I just move it into _emergency.json ?

@tyrasd
Copy link
Member

tyrasd commented Apr 10, 2024

good idea. let's try adding it to the generic _emergency.json preset

@jpds jpds force-pushed the defibrillator-check-date branch from 3576b90 to 34e4a61 Compare May 2, 2024 13:14
@jpds jpds changed the title defibrillator.json: Added check_date to fields _emergency.json: Added check_date to fields May 2, 2024
This is used by consumers such as OpenAEDMap for defibrillators.
@jpds jpds force-pushed the defibrillator-check-date branch from 34e4a61 to 09bd8cc Compare May 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants