Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add presets for ski jump tagging #1176

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

olafkryus
Copy link

Added most important presets for ski jumping venue tagging – the in-run structure, the piste and the take-off edge.

Copy link

🍱 You can preview the tagging presets of this pull request here.

"tags": {
"man_made": "ski_jump"
},
"name": "Ski Jumping Hill Structure / In-Run Tower"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this could be slightly shortened to the following?

Suggested change
"name": "Ski Jumping Hill Structure / In-Run Tower"
"name": "Ski Jumping In-Run/Tower"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in most of the cases it is true that man-made part is equal to the in-run tower.
It is also not uncommon for the man-made structure to include more than the in-run itself if the terrain is too flat (e.g.: Holmenkollen).
There are also ski jumps on slopes that happen to be just right (e.g. as seen here) and whether they really qualify as "man-made" (or "tower") is debatable.
If shortening of this (quite long I agree) name is desired, I would rather opt for Ski Jumping Hill Structure.

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks quite good already. See a few suggestions inline. In addition, could you also add the option for ski_jumping to the sport field please?

olafkryus and others added 2 commits April 1, 2024 00:58
@olafkryus
Copy link
Author

Thanks, this looks quite good already. See a few suggestions inline.

Thanks for the feedback.
I've applied one patch, and provided more info on the other – please be the judge ;)

In addition, could you also add the option for ski_jumping to the sport field please?

Sure. Done: e2f42db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants