New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add presets for ski jump tagging #1176
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
"tags": { | ||
"man_made": "ski_jump" | ||
}, | ||
"name": "Ski Jumping Hill Structure / In-Run Tower" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this could be slightly shortened to the following?
"name": "Ski Jumping Hill Structure / In-Run Tower" | |
"name": "Ski Jumping In-Run/Tower" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While in most of the cases it is true that man-made part is equal to the in-run tower.
It is also not uncommon for the man-made structure to include more than the in-run itself if the terrain is too flat (e.g.: Holmenkollen).
There are also ski jumps on slopes that happen to be just right (e.g. as seen here) and whether they really qualify as "man-made" (or "tower") is debatable.
If shortening of this (quite long I agree) name is desired, I would rather opt for Ski Jumping Hill Structure
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks quite good already. See a few suggestions inline. In addition, could you also add the option for ski_jumping
to the sport
field please?
Co-authored-by: Martin Raifer <martin@raifer.tech>
Thanks for the feedback.
Sure. Done: e2f42db |
Added most important presets for ski jumping venue tagging – the in-run structure, the piste and the take-off edge.