Introduce cycleway:both=* and make cycleway:NULL=* unsearchable
#1147
+64
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is, to work around - a deprecation of the `:NULL` variant that used to represent "both" or sometimes "the primary side" - the need to add another feature to the files which would allow to handle both keys at the same time. The idea is, to have the legacy value kind of unsearchable and only show up when the `cycleway:NULL` key is present. However, that is hard ATM because this key is also used for `crossing`, `asl` and such (https://taginfo.openstreetmap.org/keys/cycleway#values) and the `prerequisiteTag` does not allow any arrays as values, yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another take at the same issues as #1137.
The goal is, to work around
:NULLvariant that used to represent "both" or sometimes "the primary side"The idea is, to have the legacy value kind of unsearchable and only show up when the
cycleway:NULLkey is present. However, that is hard ATM because this key is also used forcrossing,asland such (https://taginfo.openstreetmap.org/keys/cycleway#values) and theprerequisiteTagdoes not allow any arrays as values, yet.Lets see how the preview behaves … but I think that the limitation of
prerequisiteTagwill make this a nonstarter as well…