chore: add tsc to test command #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philschatz
reviewed
Dec 5, 2018
package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "server": "NODE_ENV=development node script/entry server/cli", | |||
| "codecov": "codecov", | |||
| "postinstall": "node ./script/postinstall", | |||
| "test": "npm run-script test:unit && npm run-script lint && npm run-script test:build", | |||
| "test": "npm run-script test:unit && npm run-script lint && npm run-script test:build && ./node_modules/.bin/tsc", | |||
There was a problem hiding this comment.
I think this will work but have not verified
Suggested change
| "test": "npm run-script test:unit && npm run-script lint && npm run-script test:build && ./node_modules/.bin/tsc", | |
| "test": "npm run-script test:unit && npm run-script lint && npm run-script test:build && tsc", |
philschatz
previously approved these changes
Dec 5, 2018
philschatz
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until now we've been catching type errors as a function of the build commands run as part of the tests, but some type error have leaked through in the tests themselves and in the scripts which aren't compiled with the app code.
adding tsc to the test command before was annoying because of this bug microsoft/TypeScript#28202
so i've upgraded typescript to the new release with that bug fixed but now there is a different bug
microsoft/TypeScript#28748
but that one is easier to ignore and document so i've pressed on anyway.