Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bug report.yml #3946

Merged
merged 1 commit into from Mar 12, 2024
Merged

Update bug report.yml #3946

merged 1 commit into from Mar 12, 2024

Conversation

objecttothis
Copy link
Member

Add option to select a development build

Add option to select a development build
@objecttothis objecttothis self-assigned this Mar 12, 2024
@objecttothis objecttothis added this to the 3.3.10 milestone Mar 12, 2024
Copy link
Collaborator

@odiea odiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@objecttothis
Copy link
Member Author

@odiea does it allow you to approve the PR?

@odiea odiea marked this pull request as ready for review March 12, 2024 16:04
@odiea
Copy link
Collaborator

odiea commented Mar 12, 2024

Currently it does not. Squash and Merge button is disabled!
Merging can be performed automatically with 1 approving review.

@objecttothis
Copy link
Member Author

Right, I don't mean merge it. I mean does it allow you to do a code review and approve the PR.

@odiea
Copy link
Collaborator

odiea commented Mar 12, 2024

I believe it just stated leave a review.

@odiea odiea self-requested a review March 12, 2024 16:29
Copy link
Collaborator

@odiea odiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I used comment and not approve

@objecttothis objecttothis merged commit 698f9bb into master Mar 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants