Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates (#3895) #3936

Merged
merged 1 commit into from Feb 28, 2024
Merged

Update issue templates (#3895) #3936

merged 1 commit into from Feb 28, 2024

Conversation

jekkos
Copy link
Member

@jekkos jekkos commented Feb 28, 2024

Rebased @odiea work for the templates on master branch so we can use it in our repo.

Copy link
Collaborator

@odiea odiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

label: OpensourcePOS Version
description: What version of our software are you running?
options:
- opensourcepos 3.3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense here to list versions back to 3.3.2?

@odiea
Copy link
Collaborator

odiea commented Feb 28, 2024

My thoughts were if there are any old or new bugs introduced in these versions they should be dealt with. It is up to the user to update their versions to keep up with the current OSPOS versions.
I also would like to see the new CI4 version should start with 4.0.0 to show we are now on CI4.

@objecttothis
Copy link
Member

My thoughts were if there are any old or new bugs introduced in these versions they should be dealt with. It is up to the user to update their versions to keep up with the current OSPOS versions. I also would like to see the new CI4 version should start with 4.0.0 to show we are now on CI4.

@jekkos and I talked about this awhile back. Even though there is a significant amount of work involved, @jekkos had a good point that the update doesn't by itself add any new features, only scaffolding for a lot of really cool features. For this reason, he argued to make it a minor version change 3.4.0 instead of 4.0.0. Likely someone will want to redo the UI in the latest version of bootstrap and make it more responsive and that would likely warrant a major version change. Also since we are planning introducing API's and 3rd party integrations, those would also be factors in a major version change.

@objecttothis objecttothis merged commit 2618772 into master Feb 28, 2024
2 of 3 checks passed
@objecttothis objecttothis deleted the templates branch February 28, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants