Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #3804

Merged
merged 1 commit into from Aug 30, 2023
Merged

Various fixes #3804

merged 1 commit into from Aug 30, 2023

Conversation

daN4cat
Copy link
Collaborator

@daN4cat daN4cat commented Aug 30, 2023

Various minor fixes and a cashup tabular view issue (icons won't display and replaced with Yes/No)

@jekkos
Copy link
Member

jekkos commented Aug 30, 2023

Nice to see you here again after a while @daN4cat ! Will have a look at the PR.

@jekkos
Copy link
Member

jekkos commented Aug 30, 2023

I guess it's fine for master, but we'll need to port it over to ci4-upgrade branch as well as the code there was so heavily changed. I still have the language file conversion script fresh which I might now add in form of a simple shell script.

@jekkos jekkos merged commit 4806c0f into master Aug 30, 2023
3 checks passed
@daN4cat
Copy link
Collaborator Author

daN4cat commented Aug 31, 2023

I didn't find the time yet to look at the ci4 branch.
I have a couple of things to do with a fork of current master before I can move to the new version.

@daN4cat daN4cat deleted the fixes branch September 2, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants