Feature: CodeIgniter 4 upgrade #3592

jekkos · 2022-11-13T22:14:59Z

Upgrading CodeIgniter to 4.4.3 #842

Here are a list of issues that need to be resolved:

objecttothis · 2022-11-17T07:48:38Z

I've created a draft PR just to compare the two branches. We are going to need to write a special upgrade instructions document for this upgrade. @odiea do you care to do this? It will need to include things like manually moving images in item_pics, etc to the new location...

objecttothis · 2022-11-17T07:52:23Z

Does this new CI4 branch include the changes from the master that were merged since the original codeigniter_4_upgrade branch was created? Those are going to manually need to be ported to the CI4 format. If they are blindly merged in then they won't work because the syntax for many things is different.

objecttothis · 2022-11-17T11:30:23Z

@jekkos did we decide whether this version will be 3.4.0 or 4.0.0?

jekkos · 2022-11-17T22:42:59Z

@objecttothis I always thought to stick with 3.4.0, as we do not really add new features. But this might not be reflecting the fact that the upgrade was a huge effort.

app/Config/migration.php

objecttothis · 2022-11-18T06:08:22Z

@objecttothis I always thought to stick with 3.4.0, as we do not really add new features. But this might not be reflecting the fact that the upgrade was a huge effort.

That's fine. I'll push a commit.

- correct URL - Removed line endings - Removed unneeded include

- Removed esc() call that was causing problems - Renamed function to match CI4 expectations - String interpolation - corrected URL for pic_thumb

DEV-byoos · 2023-11-01T13:25:39Z

@objecttothis
the constant BASEPATH not exist on CI4, use FCPATH declared in /root/index.php

objecttothis · 2023-11-01T13:48:01Z

@objecttothis the constant BASEPATH not exist on CI4, use FCPATH declared in /root/index.php

Thank you. I will replace those instances tomorrow when I am back in the office.

DEV-byoos · 2023-11-01T15:33:00Z

Thank you @objecttothis for your quick response ho to perfect the fix link the.zip file attached to my message from ********** START debug *************
`// 2023/10/30 chaper company_log
// IN /root/ci4_opensourceospos_latest/app/Views/login.php
//FIX replace "images/" directory to "uploads/logo/"

// IN /root/ci4_opensourceospos_latest/public/config
// the "logo_exists" key is always TRUE
//replace $data['logo_exists'] = $this->config['company_logo'] != '';
// TO FIX
function getIndex() {
$data['logo_exists'] = !empty($this->config['company_logo']);
...
`
// IN /root/ci4_opensourceospos_latest/app/Views/Config/info_config.php
// replace base_url('uploads') TO base_url('images/logo/')

`// IN /root/app/Controllers/Config.php
// Method upload_logo() infos: if $file->guessExtension() is loaded after move function then not work ( /tmp/file_tmp is moved )
private function upload_logo(): array
{
helper(['form']);
$validation_rule = [
'company_logo' => [
'label' => 'Company logo',
'rules' => [
'uploaded[company_logo]',
'is_image[company_logo]',
'max_size[company_logo,1024]',
'mime_in[company_logo,image/png,image/jpg,image/gif]',
'ext_in[company_logo,png,jpg,gif]',
'max_dims[company_logo,800,680]',
]
]
];

	if (!$this->validate($validation_rule))
	{
		return (['error' => $this->validator->getError('company_logo')]);
	}
	else
	{
		$file = $this->request->getFile('company_logo');

		$file_info = [
			'orig_name' => $file->getClientName(),
			'raw_name' => $file->getName(),
			'file_ext' => $file->guessExtension(),
			'error'	   => ''
		];

		 if (! $file->hasMoved()) {
			 //$file->move(WRITEPATH . 'uploads/logo/');
			 $file->move(FCPATH.'public/images/logo/');
			 $success = $this->appconfig->save(['company_logo' => $file->getClientName()]);
		}

		return ($file_info);
	}
}`

`// INFOS: https://stackoverflow.com/questions/58728648/how-to-display-uploaded-images-in-codeigniter-4

// IN /root/app/Controllers/Config.php -> error 404, rename remove_logo TO postRemove_logo
// Method postRemove_logo() erase WRITEPATH . 'uploads/logo/' AND $dirdest = FCPATH.'images/logo/'
/ AND empty config['company_logo'] value
/**
* @throws ReflectionException
*/
public function postRemove_logo(): void
{
helper('filesystem');
$dirdest = FCPATH.'uploads/logo/';
if (file_exists($dirdest)){
delete_files($dirdest);
}

	$success = $this->appconfig->save(['company_logo' => '']);			
	echo json_encode (['success' => $success]);
}

`
Sincerely, Gabriel

objecttothis · 2023-11-02T06:23:08Z

@DEV-byoos thank you for the helpful tips. Please check out ci4-branch, make the changes there and submit a pull request against ci4-branch for these changes. I can do a code review at that time, but wading through the shorthand in your comment is difficult.

jekkos · 2023-11-05T21:20:19Z

@objecttothis should we reopen the pull request now with the new branch instead?

jekkos · 2023-11-05T21:20:59Z

@DEV-byoos indeed it might be better if you submit your fixes in a pull request. Do you know how to do that? Thanks!

objecttothis · 2023-11-05T21:28:51Z

@objecttothis should we reopen the pull request now with the new branch instead?

I think you can edit this PR so it's ci4-branch trying to merge into master instead of ci4-upgrade. It would be a shame to lose the conversation history in this PR by creating a new one.

DEV-byoos · 2023-11-06T09:18:49Z

@objecttothis hello,

Well, thank you for your suggestion but I'm not a github boss and my Internet network is weak.
While I get used to the pull-request I suggest sending you patch by patch on "Feature: CodeIgniter 4 upgrade #3592" you can test then update the ci4-upgrade, OK?
like /root/app/controllers/Config.php --- remove_logo method
FIX rename remove_logo with postRemove_logo
code
` public function postRemove_logo(): void
{
$file = FCPATH.'uploads/' . $this->config['company_logo'];
if (is_readable($file) && unlink($file)) {
$success = $this->appconfig->save(['company_logo' => '']);
} else {
$success = "The file was not found";
}
$success = $this->appconfig->save(['company_logo' => '']);

	echo json_encode (['success' => $success]);
}`

objecttothis · 2023-11-06T09:25:08Z

@objecttothis hello,

Well, thank you for your suggestion but I'm not a github boss and my Internet network is weak. While I get used to the pull-request I suggest sending you patch by patch on "Feature: CodeIgniter 4 upgrade #3592" you can test then update the ci4-upgrade, OK? like /root/app/controllers/Config.php --- remove_logo method FIX rename remove_logo with postRemove_logo code ` public function postRemove_logo(): void { $file = FCPATH.'uploads/' . $this->config['company_logo']; if (is_readable($file) && unlink($file)) { $success = $this->appconfig->save(['company_logo' => '']); } else { $success = "The file was not found"; } $success = $this->appconfig->save(['company_logo' => '']);
	echo json_encode (['success' => $success]);
}`

@owlbrudder @jekkos do either of you want to take the time to look through @DEV-byoos changes and implement them? @DEV-byoos I'm working through fixing some problems with attributes right now. I'm sorry, but I just don't have time to submit these changes myself. The formatting does not come through very well in github because you aren't using ``` before and after your code blocks. Your changes are probably very helpful, but I can't get to it. I don't know what your first language is, but I recommend reading a tutorial on how to create a branch, make changes and submit them as a pull request. You can even do these by hand in Github if you need to.

owlbrudder · 2023-11-06T09:34:09Z

This looks like something I could use to get back into working state. I am near end of day here, but I could have a look at it in the morning if that's okay?

…

On Mon, 6 Nov 2023, 5:25 pm objecttothis, ***@***.***> wrote: @objecttothis <https://github.com/objecttothis> hello, Well, thank you for your suggestion but I'm not a github boss and my Internet network is weak. While I get used to the pull-request I suggest sending you patch by patch on "Feature: CodeIgniter 4 upgrade #3592 <#3592>" you can test then update the ci4-upgrade, OK? like /root/app/controllers/Config.php --- remove_logo method FIX rename remove_logo with postRemove_logo code ` public function postRemove_logo(): void { $file = FCPATH.'uploads/' . $this->config['company_logo']; if (is_readable($file) && unlink($file)) { $success = $this->appconfig->save(['company_logo' => '']); } else { $success = "The file was not found"; } $success = $this->appconfig->save(['company_logo' => '']); echo json_encode (['success' => $success]); }` @owlbrudder <https://github.com/owlbrudder> @jekkos <https://github.com/jekkos> do either of you want to take the time to look through @DEV-byoos <https://github.com/DEV-byoos> changes and implement them? @DEV-byoos <https://github.com/DEV-byoos> I'm working through fixing some problems with attributes right now. I'm sorry, but I just don't have time to submit these changes myself. The formatting does not come through very well in github because you aren't using \``` before and after your code blocks. Your changes are probably very helpful, but I can't get to it. I don't know what your first language is, but I recommend reading a tutorial on how to create a branch, make changes and submit them as a pull request. You can even do these by hand in Github if you need to. — Reply to this email directly, view it on GitHub <#3592 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2THY7F5ODY2MCVURT75JLYDCUIBAVCNFSM6AAAAAAR7HQVR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGM4TMNRZGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

DEV-byoos · 2023-11-06T10:58:41Z

DAY 1
thanks @owlbrudder

following explanation:
the company_logo config option allows you to replace the OSPOS logo with the company logo, OK

Add company logo YES
validate the config modification YES after fix
delete the logo NO because it does not disappear on disk, only in the database TABLE ospos_app_config KEY company_logo
if we reload a new company logo the name on the disk will be indexed filename_1...
NOTE company logo can only be loaded once.
Like /root/app/controllers/Config.php --- remove_logo method
FIX rename remove_logo with postRemove_logo
code

  	public function postRemove_logo(): void
	{
		$file = FCPATH.'uploads/' . $this->config['company_logo'];
		if (is_readable($file) && unlink($file)) {
			$success = $this->appconfig->save(['company_logo' => '']);
		} else {
			$success = "The file was not found";
		}
		$success = $this->appconfig->save(['company_logo' => '']);
		
		echo json_encode (['success' => $success]);
	}

PS I use code tags, I don't understand why it's buggy??? OK I found thanks @objecttothis your code
best regards

owlbrudder · 2023-11-06T11:07:28Z

Thanks for the explanation. I will look at it all in the morning and get back to you.

…

On Mon, 6 Nov 2023, 6:58 pm BYOOS, ***@***.***> wrote: thanks @owlbrudder <https://github.com/owlbrudder> following explanation: the company_logo config option allows you to replace the OSPOS logo with the company logo, OK 1. Add company logo YES 2. validate the config modification YES after fix 3. delete the logo NO because it does not disappear on disk, only in the database TABLE ospos_app_config KEY company_logo 4. if we reload a new company logo the name on the disk will be indexed filename_1... NOTE company logo can only be loaded once. ike /root/app/controllers/Config.php --- remove_logo method FIX rename remove_logo with postRemove_logo code ` public function postRemove_logo(): void { $file = FCPATH.'uploads/' . $this->config['company_logo']; if (is_readable($file) && unlink($file)) { $success = $this->appconfig->save(['company_logo' => '']); } else { $success = "The file was not found"; } $success = $this->appconfig->save(['company_logo' => '']); echo json_encode (['success' => $success]); }` PS I use code tags, I don't understand why it's buggy??? best regards — Reply to this email directly, view it on GitHub <#3592 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE2THYZTRA4FSMUUJURYCFTYDC7G3AVCNFSM6AAAAAAR7HQVR2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUGU3DEMJYGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

DEV-byoos · 2023-11-06T16:40:50Z

@DEV-byoos indeed it might be better if you submit your fixes in a pull request. Do you know how to do that? Thanks!

Answer @DEV-byoos
@jekkos
en fait je n'utilise GITHUB seulement pour mes dépôts ou fork et le téléchargement de projet ho mais je vais essayer de trouver un bon tuto pour apprendre cela.

jekkos · 2023-11-06T16:49:17Z

4. if we reload a new company logo the name on the disk will be indexed filename_1...
NOTE company logo can only be loaded once.
Like /root/app/controllers/Config.php --- remove_logo method
FIX rename remove_logo with postRemove_logo
code

Ca sera bon si tu apprendrais a faire un requet tirer. Ou autrement vous pouvez justement envoyer un diff generé par git. Je pense que ca va etre plus facile a inspecter;

jekkos · 2023-11-06T16:56:17Z

@objecttothis should we reopen the pull request now with the new branch instead?

I think you can edit this PR so it's ci4-branch trying to merge into master instead of ci4-upgrade. It would be a shame to lose the conversation history in this PR by creating a new one.

I checked this, you can only change the target branch, but not the source. Which might make sense. The conflicts we see here are resolved in the other branch. I can copy the content of the issue list here to a new PR.
The history will remain then in this conversation, in my opinion it has become already a bit too long.

jekkos · 2023-11-06T16:57:03Z

DAY 1 thanks @owlbrudder

following explanation: the company_logo config option allows you to replace the OSPOS logo with the company logo, OK

1. Add company logo YES

2. validate the config modification YES after fix

3. delete the logo NO because it does not disappear on disk, only in the database TABLE ospos_app_config KEY company_logo

4. if we reload a new company logo the name on the disk will be indexed filename_1...
   NOTE company logo can only be loaded once.
   Like /root/app/controllers/Config.php --- remove_logo method
   FIX rename remove_logo with postRemove_logo
   code

  	public function postRemove_logo(): void
	{
		$file = FCPATH.'uploads/' . $this->config['company_logo'];
		if (is_readable($file) && unlink($file)) {
			$success = $this->appconfig->save(['company_logo' => '']);
		} else {
			$success = "The file was not found";
		}
		$success = $this->appconfig->save(['company_logo' => '']);
		
		echo json_encode (['success' => $success]);
	}

PS I use code tags, I don't understand why it's buggy??? best regards

Thanks for the proposition. Regarding the function rename, I would not mix camelcase with snake case. In this case camelcase is the way to go.

DEV-byoos · 2023-11-06T17:41:14Z

DAY 2
thanks @owlbrudder

following explanation:
updating the company logo in its original version works but generates two critical errors in php 8.2 -- php8.3
let me explain ho, it all starts with the info_config.php form
<?php echo form_open('config/saveInfo/',
when validating "change image" on POST to controller /root/app/Controllers/Config.php postSaveInfo method

$upload_success = !empty($upload_data['error']); the variable $upload_success is not loaded ( !isset ) and causes a critical error on line 357 $message = $upload_success ? $message: strip_tags($upload_data['error']);
fix in upload_logo method.

coded

	private function upload_logo(): array
	{
		helper(['form']);
		$validation_rule = [
			'company_logo' => [
				'label' => 'Company logo',
				'rules' => [
					'uploaded[company_logo]',
					'is_image[company_logo]',
					'max_size[company_logo,1024]',
					'mime_in[company_logo,image/png,image/jpg,image/gif]',
					'ext_in[company_logo,png,jpg,gif]',
					'max_dims[company_logo,800,680]',
				]
			]
		];

		if (!$this->validate($validation_rule))
		{
			return (['error' => $this->validator->getError('company_logo')]);
		}
		else
		{
			$file = $this->request->getFile('company_logo');

			$file_info = [
				'orig_name' => $file->getClientName(),
				'raw_name' => $file->getName(),
				'file_ext' => $file->guessExtension(),
				'error'	   => ''
			];

			 if (! $file->hasMoved()) {
				 $file->move(FCPATH.'uploads/');
				 $success = $this->appconfig->save(['company_logo' => $file->getClientName()]);
			}

			return ($file_info);
		}
	}

the $file_info = [...] block is moved up and an 'error' key is added to initialize the value to empty.
I hope this will be clear enough because I'm doing it with what I have.
bye see you tomorrow
PS // INFOS: https://stackoverflow.com/questions/58728648/how-to-display-uploaded-images-in-codeigniter-4

objecttothis · 2023-11-06T18:18:07Z

@DEV-byoos this comment section is going to get long and chaotic. Please use Element (formerly glitter). You can use their online client or download a client on their website (https://matrix.org/ecosystem/clients/element/) just change the server to gitter.im. I will send you an invite to the dev room of opensourcepos. Just use your GitHub account to login.

We will be closing and deleting this PR soon since the other PR is what will be merged with the master. post a message to opensourcepos/Lobby and I'll send the invite to opensourcepos/devroom

objecttothis · 2023-11-07T06:58:11Z

I'm closing this PR as it will not be one we will merge. See #3858

jekkos mentioned this pull request Nov 13, 2022

CI4: Merge changes from the Master into #3271 #3585

Closed

jekkos force-pushed the ci4-upgrade branch 3 times, most recently from 8fa7b51 to d81ce55 Compare November 13, 2022 23:18

objecttothis changed the title ~~Ci4 upgrade~~ CI4 upgrade (New) Nov 17, 2022

jekkos commented Nov 17, 2022

View reviewed changes

app/Config/migration.php Outdated Show resolved Hide resolved

jekkos force-pushed the ci4-upgrade branch from 0777390 to ea5758d Compare November 20, 2022 22:50

objecttothis mentioned this pull request Nov 28, 2022

CI4: OSPOS Function signatures not compatible with CI4 #3602

Closed

objecttothis linked an issue Nov 28, 2022 that may be closed by this pull request

CI4: OSPOS Function signatures not compatible with CI4 #3602

Closed

objecttothis mentioned this pull request Dec 10, 2022

CI4: Rework file permission and package checker for CI4 #3611

Open

objecttothis self-assigned this Dec 10, 2022

objecttothis added this to the 3.4.0 milestone Dec 10, 2022

objecttothis added enhancement needs owner Epic labels Dec 10, 2022

objecttothis mentioned this pull request Dec 10, 2022

Secure hardening of web pages #3217

Open

objecttothis added 5 commits October 31, 2023 14:23

Bump to allow php 8.1

1a1497c

Fix Company logo location

022a9ba

Fix Company logo location

27a8c62

- correct URL - Removed line endings - Removed unneeded include

Fix item_pics

b212533

- Removed esc() call that was causing problems - Renamed function to match CI4 expectations - String interpolation - corrected URL for pic_thumb

Fixed incorrect language line

246ea27

jekkos force-pushed the ci4-upgrade branch 2 times, most recently from 322e357 to 246ea27 Compare November 1, 2023 00:09

Replaced BASEPATH with FCPATH

36fc66f

objecttothis changed the title ~~CI4 upgrade (New)~~ Feature: CodeIgniter 4 upgrade Nov 3, 2023

objecttothis closed this Nov 7, 2023

objecttothis deleted the ci4-upgrade branch December 4, 2023 11:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: CodeIgniter 4 upgrade #3592

Feature: CodeIgniter 4 upgrade #3592

jekkos commented Nov 13, 2022 •

edited

objecttothis commented Nov 17, 2022

objecttothis commented Nov 17, 2022

objecttothis commented Nov 17, 2022 •

edited

jekkos commented Nov 17, 2022 •

edited

objecttothis commented Nov 18, 2022

DEV-byoos commented Nov 1, 2023

objecttothis commented Nov 1, 2023

DEV-byoos commented Nov 1, 2023 •

edited

objecttothis commented Nov 2, 2023

jekkos commented Nov 5, 2023

jekkos commented Nov 5, 2023

objecttothis commented Nov 5, 2023

DEV-byoos commented Nov 6, 2023

objecttothis commented Nov 6, 2023 •

edited

owlbrudder commented Nov 6, 2023 via email

DEV-byoos commented Nov 6, 2023 •

edited

owlbrudder commented Nov 6, 2023 via email

DEV-byoos commented Nov 6, 2023

jekkos commented Nov 6, 2023

jekkos commented Nov 6, 2023

jekkos commented Nov 6, 2023

DEV-byoos commented Nov 6, 2023 •

edited

objecttothis commented Nov 6, 2023 •

edited

objecttothis commented Nov 7, 2023

Feature: CodeIgniter 4 upgrade #3592

Feature: CodeIgniter 4 upgrade #3592

Conversation

jekkos commented Nov 13, 2022 • edited

objecttothis commented Nov 17, 2022

objecttothis commented Nov 17, 2022

objecttothis commented Nov 17, 2022 • edited

jekkos commented Nov 17, 2022 • edited

objecttothis commented Nov 18, 2022

DEV-byoos commented Nov 1, 2023

objecttothis commented Nov 1, 2023

DEV-byoos commented Nov 1, 2023 • edited

objecttothis commented Nov 2, 2023

jekkos commented Nov 5, 2023

jekkos commented Nov 5, 2023

objecttothis commented Nov 5, 2023

DEV-byoos commented Nov 6, 2023

objecttothis commented Nov 6, 2023 • edited

owlbrudder commented Nov 6, 2023 via email

DEV-byoos commented Nov 6, 2023 • edited

owlbrudder commented Nov 6, 2023 via email

DEV-byoos commented Nov 6, 2023

jekkos commented Nov 6, 2023

jekkos commented Nov 6, 2023

jekkos commented Nov 6, 2023

DEV-byoos commented Nov 6, 2023 • edited

objecttothis commented Nov 6, 2023 • edited

objecttothis commented Nov 7, 2023

jekkos commented Nov 13, 2022 •

edited

objecttothis commented Nov 17, 2022 •

edited

jekkos commented Nov 17, 2022 •

edited

DEV-byoos commented Nov 1, 2023 •

edited

objecttothis commented Nov 6, 2023 •

edited

DEV-byoos commented Nov 6, 2023 •

edited

DEV-byoos commented Nov 6, 2023 •

edited

objecttothis commented Nov 6, 2023 •

edited