Add the Frame Orientation Constraint #670
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a custom constraint created by Simon Jeng in OpenSim Moco. This constraint is of MocoPathConstraint class, and constrains the relative angle between two frames. The constraint was developed for two-dimensional model in the sagittal plane (the plane perpendicular to the z axis, exactly), because 2D is enough in my research. If this constraint is needed in Moco, we can improve it to adapt three-dimensional models. This is the first time for me to pull requests in Github. If more information is required, pleas let me know. Thanks, Simon Jeng
zhengsizehrb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a custom constraint created by Simon Jeng to constrain the relative angle between two frames. This constraint is of MocoPathConstraint class, and has been briefly discussed here. The constraint was developed for two-dimensional model in the sagittal plane (the plane perpendicular to the z axis, exactly), because 2D is enough in my research. If this constraint is needed in Moco, we can improve it to adapt three-dimensional models.
This is the first time for me to use and pull requests in Github. If more information is required, pleas let me know.
Thanks,
Simon Jeng
Fixes issue #<issue_number>
This change is