Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch reduce propertyaccess wrap #3301

Open
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

aymanhab
Copy link
Member

@aymanhab aymanhab commented Oct 17, 2022

Fixes issue #0

Brief summary of changes

Improve performance by:

  • Incorporate fix to cylinder wrap from @adamkewley
  • Improve memory allocation: pre-allocate arrays to avoid copying contents to grow incrementally
  • cache properties into local variables
  • Move loop invariant calculations outside loops
  • Minor cleanup to remove old macros that expand to std functions for clarity
  • leverage the fact that calculation is done in wrapObject's own coordinate system.

Testing I've completed

Looking for feedback on...

CHANGELOG.md (choose one)

  • no need to update because...
  • updated.

This change is Reviewable

Travis CI and others added 30 commits March 16, 2022 12:26
Undo cache dependencies on ubuntu since compiler libgc has moved/upgraded
…er-make-spiral-path' into branch_reduce_propertyaccess_wrap (refactoring of CalcWrapPoint from Adam with additional optimizations for memory management purposes
…nce size is known to avoid allocation/deallocation/copying overhead. Also move loop invariant calculations outside loops
Base automatically changed from test_wrapping_algorithm to main January 20, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant