Timekeeping on OpenBeken without NTP #1167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set #defines for clock functions to 1 . So automatic builds for the platforms will include the new functions (and can be tested) to be reversed later before merging ...
Open
switched to daylight saving time calculation (derived from Tasmota DST handling)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add as many #if s as possible, though impact is not too much (for OpenLN882H just the clock, without handling of daylight saving time, its less than 500 bytes more compared to "OpenLN882H_1.17.534.bin").
The main part results from the Javascript extensions, which I can't "comment out" without making a separate section outside the "gulp-ed" part in "new_http.c".
I would be pleased to get some feedback if it works on other platforms!