-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two feature gates : Image based deployment and additional runtimeClasses #394
Closed
Closed
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
27a7e94
Move featuregates to separate package
bpradipt b6bacc1
Add method to check for feature cm
bpradipt 2559ba0
Add support for layered image based deployment
bpradipt c4de12f
Add separate event handler for configmap updates
bpradipt c69ccba
Allow multiple runtimeClass creation
bpradipt 1fc86ae
Add feature for creating additional runtimeClasses
bpradipt 36272dc
Update featuregate sample yaml
bpradipt d1eea4b
remove unused method
bpradipt fb547fe
Rename DefaultFeatureGates to DefaultFeatureGatesStatus
bpradipt 0e53603
Handle featuregate cm delete
bpradipt 6c004fd
Create featuregate status configmap at start
bpradipt 9e96e8d
Handle missing featuregate status configmap
bpradipt c59f99b
Remove duplicate code for reading yamls
bpradipt 27599db
Rename FeatureGatesConfigMapName to FeatureGatesStatusConfigMapName
bpradipt 9a30d74
Revert fg status configmap to default on KataConfig deletion
bpradipt 5f47dc5
Add unit tests for fg method
bpradipt File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it would be cleaner, and simpler too, to just remove the cm here. As I said elsewhere, I'm far from convinced that we should insist on this configmap's existence in the first place, but it definitely serves no purpose when there's even no KataConfig instance, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm also not sure why do we need to update the user's CM? This might look strange from the user's PoV having some settings changed. We should not mix default values and user's values. Whoever create it shouldn't be the one responsible for deleting?
Not a k8s expert, and I was not following all the discussions here closely, so I'm probably missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a very good point, we should avoid muddying the notion of resource ownership to avoid problems like we had a while ago with
KataConfig.spec.kataMonitorImage
which was basically an OSC-owned field within a user-ownerKataConfig
instance.However, my takeaway from the latest round of discussions is that we're now leaning towards the controller not requiring the existence of any of the feature-gating configmaps. This solves the ownership issue quite neatly by putting the configmap resources wholly under user control.