Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: cloud credentials controller #382

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

snir911
Copy link
Contributor

@snir911 snir911 commented Mar 27, 2024

This series disables the kataConfig controller testing and adds basic testing for the credentials operator against KataConfig events.
Since KataConfig Controller tests are broken ATM we need to improve mimicking standard cluster and then add more test cases

when TEST_USE_RELATIVE_PATH is set
you may need to remove openshift_controller_test.go to test
when peer-pods disabled kataconfig fails to be deleted for some reason
need to check into it, possibly because of finalizer"
@snir911 snir911 requested review from bpradipt and pmores March 27, 2024 09:36
@snir911 snir911 self-assigned this Mar 27, 2024
@openshift-ci openshift-ci bot requested a review from gkurz March 27, 2024 09:38
Copy link

openshift-ci bot commented Mar 27, 2024

@snir911: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check 332d301 link false /test check
ci/prow/sandboxed-containers-operator-e2e 332d301 link false /test sandboxed-containers-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @snir911
This lays the foundation to add tests for other pieces.
We really need to figure out how to test the reconcile loop for KataConfig which depends on MCP. But that's for other time :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants