Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPQE-21276: Add handle for customize api_port #51488

Merged
merged 1 commit into from May 2, 2024
Merged

OCPQE-21276: Add handle for customize api_port #51488

merged 1 commit into from May 2, 2024

Conversation

liangxia
Copy link
Member

@liangxia liangxia commented Apr 30, 2024 •
edited

In cucushift-pre, we set BUSHSLICER_CONFIG to,

global:
    browser: chrome
environments:
    ocp4:
        api_port: "34567"
        version: "4.16"

but then in upgrade-prepare/check, we set BUSHSLICER_CONFIG to,

environments:
    ocp4:
        static_users_map:
            upuser1: "xxxxxx"
            upuser2: "yyyyyy"

which override the api_port and version.
When api_port is the default one, it does not break the tests. However if the OCP cluster is using a customize api_port, then cucushift-upgrade-prepare/check can not connect to the cluster.

@openshift-ci-robot
Copy link
Contributor

@liangxia: No Jira issue with key OCP-21276 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from dis016 and jhou1 April 30, 2024 02:13
@liangxia liangxia changed the title OCP-21276: Add handle for customize api_port OCPQE-21276: Add handle for customize api_port Apr 30, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 30, 2024 •
edited by openshift-ci bot

@liangxia: This pull request references OCPQE-21276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liangxia: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.12-multi-nightly-aws-ipi-sdn-migration-ovn-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.13-gcp-ipi-proxy-private-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-azure-ipi-sdn-migration-ovn-amd-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-vsphere-ipi-compact-etcd-encryption-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-aws-ipi-ovn-ipsec-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-vsphere-ipi-ovn-ipsec-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-multi-nightly-azure-ipi-sdn-migration-ovn-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.3-aws-ipi-f30 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-eus-4.14-ibmcloud-ipi-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-arm64-nightly-4.12-upgrade-from-stable-4.12-azure-ipi-ovn-ipsec-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-azure-upi-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-imdsv2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-4.14-upgrade-from-stable-4.13-aws-ipi-byo-route53-compact-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-azure-ipi-mixed-ingress-internal-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-4.11-upgrade-from-stable-4.11-azure-upi-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-4.16-upgrade-from-stable-4.15-baremetal-upi-ovn-dual-stack-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-4.14-upgrade-from-stable-4.14-aws-ipi-ovn-ipsec-arm-mixarch-day2-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-amd64-nightly-4.15-upgrade-from-stable-4.14-azure-ipi-workers-rhel8-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-4.11-upgrade-from-stable-4.11-aws-ipi-private-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-vsphere-ipi-ovn-ipsec-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.11-baremetalds-ipi-ovn-ipv4-fips-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-aws-ipi-network-mtu-localzone-sdn-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-arm64-nightly-4.15-upgrade-from-stable-4.14-aws-ipi-disc-priv-sts-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.11-amd64-nightly-4.11-upgrade-from-stable-4.11-aws-ipi-byo-route53-f360 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.13-amd64-nightly-4.13-upgrade-from-stable-4.12-aws-ipi-disc-priv-f28 N/A periodic Registry content changed

A total of 772 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@liangxia
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.13-aws-ipi-imdsv2-f28

@openshift-ci-robot
Copy link
Contributor

@liangxia: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@liangxia
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-vsphere-ipi-ovn-ipsec-f28

@openshift-ci-robot
Copy link
Contributor

@liangxia: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 30, 2024 •
edited by openshift-ci bot

@liangxia: This pull request references OCPQE-21276 which is a valid jira issue.

In response to this:

In cucushift-pre, we set BUSHSLICER_CONFIG to,

global:
   browser: chrome
environments:
   ocp4:
       api_port: "34567"
       version: "4.16"

but then in upgrade-prepare/check, we set BUSHSLICER_CONFIG to,

environments:
   ocp4:
       static_users_map:
           upuser1: "xxxxxx"
           upuser2: "yyyyyy"

which override the api_port and version.
When api_port is the default one, it does not break the tests. However if the OCP cluster is using a customize api_port, then cucushift-upgrade-prepare/check can not connect to the cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@liangxia
Copy link
Member Author

/cc @JianLi-RH @dis016 @pruan-rht @jhou1

@liangxia
Copy link
Member Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@liangxia: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@liangxia
Copy link
Member Author

/test ci-operator-registry

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@liangxia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-vsphere-ipi-ovn-ipsec-f28 c24302d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.12-amd64-nightly-4.12-upgrade-from-stable-4.12-vsphere-ipi-ovn-ipsec-f28
ci/rehearse/periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.13-aws-ipi-imdsv2-f28 c24302d link unknown /pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.13-arm64-nightly-4.13-upgrade-from-stable-4.13-aws-ipi-imdsv2-f28

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pruan-rht
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia, pruan-rht

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 19d9681 into openshift:master May 2, 2024
12 of 14 checks passed
@liangxia liangxia deleted the jira21276 branch May 6, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dis016 dis016 Awaiting requested review from dis016

@jhou1 jhou1 Awaiting requested review from jhou1

@JianLi-RH JianLi-RH Awaiting requested review from JianLi-RH

@pruan-rht pruan-rht Awaiting requested review from pruan-rht

Assignees

@pruan-rht pruan-rht

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@liangxia @openshift-ci-robot @pruan-rht