Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version of odh/modelmesh-serving pipeline #51485

Merged

Conversation

israel-hdez
Copy link
Contributor

@israel-hdez israel-hdez commented Apr 29, 2024

Upgrade to go1.20, from go1.19.
This is required for Model Mesh v0.12

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@israel-hdez israel-hdez force-pushed the modelmesh-update-go-version branch 3 times, most recently from 137baed to a218ff6 Compare April 30, 2024 00:02
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@israel-hdez: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-opendatahub-io-modelmesh-serving-main-images opendatahub-io/modelmesh-serving presubmit Ci-operator config changed
pull-ci-opendatahub-io-modelmesh-serving-main-pr-image-mirror opendatahub-io/modelmesh-serving presubmit Ci-operator config changed
pull-ci-opendatahub-io-modelmesh-serving-main-unit opendatahub-io/modelmesh-serving presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Contributor

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link
Contributor Author

/retest

@israel-hdez
Copy link
Contributor Author

/pj-rehearse pull-ci-opendatahub-io-modelmesh-serving-main-images pull-ci-opendatahub-io-modelmesh-serving-main-unit

@openshift-ci-robot
Copy link
Contributor

@israel-hdez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@israel-hdez
Copy link
Contributor Author

/pj-rehearse pull-ci-opendatahub-io-modelmesh-serving-main-images pull-ci-opendatahub-io-modelmesh-serving-main-unit

@openshift-ci-robot
Copy link
Contributor

@israel-hdez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@israel-hdez
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@israel-hdez: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@israel-hdez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e554d76 into openshift:master Apr 30, 2024
17 checks passed
@israel-hdez israel-hdez deleted the modelmesh-update-go-version branch April 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants