Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-logging-operator: Apply #51317 to release-5.9 #51478

Merged

Conversation

periklis
Copy link
Contributor

@periklis
Copy link
Contributor Author

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@xperimental
Copy link
Contributor

/pj-rehearse pull-ci-openshift-cluster-logging-operator-release-5.9-images

@openshift-ci-robot
Copy link
Contributor

@xperimental: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@periklis
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9757d37 and 2 for PR HEAD 85bceda in total

@periklis
Copy link
Contributor Author

/retest-required

@periklis
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 372db3f and 1 for PR HEAD 85bceda in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@periklis: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-logging-operator-release-5.9-ci-index-cluster-logging-operator-bundle openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-release-5.9-e2e-target openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-release-5.9-functional-target openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-release-5.9-images openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-release-5.9-lint openshift/cluster-logging-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-logging-operator-release-5.9-unit openshift/cluster-logging-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@periklis
Copy link
Contributor Author

/pj-rehearse more

@openshift-ci-robot
Copy link
Contributor

@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@xperimental
Copy link
Contributor

The rehearsals fail on the Go 1.21 error we try to fix with the open PR. The ci-operator-registry failure looks like a transient CI failure. I'd say you're safe to accept the rehearsals at this stage.

@xperimental
Copy link
Contributor

/retest-required

@periklis
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@periklis: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@vparfonov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, periklis, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@periklis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cluster-logging-operator/release-5.9/unit 126861a link unknown /pj-rehearse pull-ci-openshift-cluster-logging-operator-release-5.9-unit
ci/rehearse/openshift/cluster-logging-operator/release-5.9/lint 126861a link unknown /pj-rehearse pull-ci-openshift-cluster-logging-operator-release-5.9-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8997f1c into openshift:master Apr 30, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants