Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLAT-1599: Added support for secure boot and storage policies. #51474

Merged
merged 1 commit into from Apr 30, 2024

Conversation

vr4manta
Copy link
Contributor

SPLAT-1599

Changes

  • Updated scripts to configure 2 new variables: storagepolicy and secureboot

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 29, 2024

@vr4manta: This pull request references SPLAT-1599 which is a valid jira issue.

In response to this:

SPLAT-1599

Changes

  • Updated scripts to configure 2 new variables: storagepolicy and secureboot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@vr4manta: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-origin-master-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.17-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.13-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.12-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.11-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.10-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.9-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.8-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.7-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.6-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.5-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.4-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.3-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.2-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.1-e2e-vsphere openshift/origin presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-master-e2e-ovn-vsphere openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.17-e2e-ovn-vsphere openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.16-e2e-ovn-vsphere openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.15-e2e-ovn-vsphere openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.14-e2e-ovn-vsphere openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-vsphere-ovn openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.12-e2e-vsphere-ovn openshift/cluster-storage-operator presubmit Registry content changed

A total of 228 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@vr4manta vr4manta marked this pull request as ready for review April 30, 2024 11:23
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@openshift-ci openshift-ci bot requested review from dgoodwin and neisw April 30, 2024 11:24
@jcpowermac
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
Copy link
Contributor

openshift-ci bot commented Apr 30, 2024

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@vr4manta: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d0b3832 into openshift:master Apr 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants