Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] use the proper cert to verify the oauth-server #28773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented May 6, 2024

I don't plan to finish out or refactor to make it more reasonable, but hopefully this explains better than my previous words.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-ci openshift-ci bot requested review from sjenning and soltysh May 6, 2024 20:44
Copy link
Contributor

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@@ -222,6 +222,11 @@ func waitForOAuthServerPodReady(oc *exutil.CLI) error {
}

func waitForOAuthServerRouteReady(oc *exutil.CLI) error {
routerSecret, err := oc.AdminKubeClient().CoreV1().Secrets("openshift-config-managed").Get(context.Background(), "router-certs", metav1.GetOptions{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should use the default-ingress-cert CM instead.

Copy link
Contributor

openshift-ci bot commented May 8, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-cgroupsv2 6242455 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-single-node-serial 6242455 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 6242455 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-openstack-ovn 6242455 link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 6242455 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp-ovn 6242455 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-sdn 6242455 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-ovn-single-node-upgrade 6242455 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-gcp-ovn-builds 6242455 link true /test e2e-gcp-ovn-builds
ci/prow/e2e-gcp-csi 6242455 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-fips 6242455 link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-edge-zones 6242455 link true /test e2e-aws-ovn-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants