Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enterprise-4.14] OCPBUGS#33113: Doc improvements related to volume cloning/snapshots #75330

Merged
merged 1 commit into from May 8, 2024
Merged

[enterprise-4.14] OCPBUGS#33113: Doc improvements related to volume cloning/snapshots #75330

merged 1 commit into from May 8, 2024

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Apr 30, 2024 •
edited

Version(s):
4.14

Issue:
OCPBUGS-33113

Link to docs preview:
Preview

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 30, 2024
@sr1kar99 sr1kar99 force-pushed the 33133-volume-clone-and-snapshot-doc-improv branch from a9be771 to e92c11e Compare April 30, 2024 06:56
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2024
@sr1kar99 sr1kar99 changed the title OCPBUGS#33113: Doc improvements related to volume cloning/snapshots [enterprise-4.14] OCPBUGS#33113: Doc improvements related to volume cloning/snapshots Apr 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 30, 2024 •
edited

🤖 Wed May 08 12:08:44 - Prow CI generated the docs preview:

https://75330--ocpdocs-pr.netlify.app/
https://75330--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

@sr1kar99
Copy link
Contributor Author

@jakobmoellerdev @suleymanakbas91
Can you please review this PR?
Thanks!

@suleymanakbas91
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 3, 2024

@radeore
Can you please review this PR?
Thanks!

@radeore
Copy link

radeore commented May 6, 2024

Hi @sr1kar99 , added few comments, other then that LGTM. Thanks!

@sr1kar99 sr1kar99 force-pushed the 33133-volume-clone-and-snapshot-doc-improv branch from e92c11e to cff81b3 Compare May 7, 2024 04:51
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2024

New changes are detected. LGTM label has been removed.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2024
@adellape adellape self-assigned this May 7, 2024
@adellape adellape added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2024
@adellape adellape added this to the Continuous Release milestone May 8, 2024
adellape
adellape reviewed May 8, 2024
View reviewed changes
storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.adoc

//Volume cloning
include::modules/lvms-volume-clones-in-single-node-openshift.adoc[leveloffset=+1]
include::modules/lvms-creating-volume-clones-in-single-node-openshift.adoc[leveloffset=+2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, there is one existing external link in the openshift-docs repo to this file on the Customer Portal, from a Microshift assembly:

https://github.com/openshift/openshift-docs/blob/main/microshift_storage/volume-snapshots-microshift.adoc?plain=1#L96

It won't 404 (it just dumps to the top of the page on the Portal), but you might want to update that link: to the new module location / URL. Possibly cross-check with a member of the Microshift docs team.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great catch! Thanks @adellape
I've informed a writer from the MicroShift team. This link will be updated upon merging this PR.
Thanks!

modules/lvms-about-volume-snapshots.adoc Outdated Show resolved Hide resolved
@adellape
Copy link
Contributor

adellape commented May 8, 2024 •
edited

@sr1kar99 Can you confirm whether #71446 is more or less the 4.15+ equivalent PR for this similar content? To make it clear during merge-review why this is only targeting the enterprise-4.14 branch. Thanks!

@adellape adellape added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels May 8, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 8, 2024

@sr1kar99 Can you confirm whether #71446 is more or less the 4.15+ equivalent PR for this similar content? To make it clear during merge-review why this is only targeting the enterprise-4.14 branch. Thanks!

Hi @adellape
Yes! You are right. Similar PR for 4.15+ has been merged already. The reason for having a separate PR for 4.14 is that 4.14 and lower versions support this Operator only on single-node OpenShift.

Thanks for adding the 4.15+ PR link. :)

@sr1kar99 sr1kar99 force-pushed the 33133-volume-clone-and-snapshot-doc-improv branch from cff81b3 to 5332e10 Compare May 8, 2024 11:11
@sr1kar99 sr1kar99 force-pushed the 33133-volume-clone-and-snapshot-doc-improv branch from 5332e10 to 3e0c724 Compare May 8, 2024 12:00
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 8, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 8, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label May 8, 2024
@adellape adellape merged commit 6174693 into openshift:enterprise-4.14 May 8, 2024
3 checks passed
@adellape adellape removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adellape adellape adellape left review comments

@radeore radeore radeore left review comments

Assignees

@adellape adellape

@suleymanakbas91 suleymanakbas91

Labels
branch/enterprise-4.14 peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sr1kar99 @ocpdocs-previewbot @suleymanakbas91 @radeore @adellape