Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHACS] Update Alpine Linux version format in release notes #75329

Conversation

gaurav-nelson
Copy link
Contributor

@gaurav-nelson gaurav-nelson commented Apr 30, 2024

For https://issues.redhat.com/browse/ROX-16826

Added an item under Notable technical changes listing the change.

Preview: https://75329--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/44-release-notes.html#notable-technical-changes_release-notes-44

Cherrypick:

  • rhacs-docs-4.4

NOTE:

  • This PR is for RHACS docs.
  • It doesn't require any special labels or milestones.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 30, 2024
@gaurav-nelson gaurav-nelson added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 rhacs-docs-4.5 and removed rhacs-docs-4.5 labels Apr 30, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 30, 2024

🤖 Tue May 07 08:12:35 - Prow CI generated the docs preview:

https://75329--ocpdocs-pr.netlify.app/openshift-acs/latest/release_notes/44-release-notes.html

@gaurav-nelson gaurav-nelson added the peer-review-needed Signifies that the peer review team needs to review this PR label May 1, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

Hi @gaurav-nelson . A heads-up that this commit might have merge conflicts.

@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-in-progress

/label peer-review-done

@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

Hi @gaurav-nelson . WOuld a change management be need for this update (it's a change to existing release notes)?

See the Change Management section in the OCP Docs Manual.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 2, 2024
@gaurav-nelson
Copy link
Contributor Author

Thank you @dfitzmau This is a minor change so we don't need to follow that. I'll update the branch to fix the conflicts.

Copy link

openshift-ci bot commented May 7, 2024

@gaurav-nelson: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gaurav-nelson gaurav-nelson merged commit f042161 into openshift:rhacs-docs-main May 7, 2024
3 checks passed
@gaurav-nelson
Copy link
Contributor Author

/cherrypick rhacs-docs-4.4

@openshift-cherrypick-robot

@gaurav-nelson: new pull request created: #75587

In response to this:

/cherrypick rhacs-docs-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.4 Label for PRs that apply to RHACS 4.4 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants