Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCIDOCS-176: Remove Dell idrac9 firmware note #75296

Merged
merged 1 commit into from May 3, 2024
Merged

HCIDOCS-176: Remove Dell idrac9 firmware note #75296

merged 1 commit into from May 3, 2024

Conversation

kdrake20
Copy link
Contributor

@kdrake20 kdrake20 commented Apr 29, 2024 •
edited

Fixes: HCIDOCS-176

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Drake kdrake@redhat.com

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot

@kdrake20: This pull request references HCIDOCS-176 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-176

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Drake kdrake@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot

@kdrake20: This pull request references HCIDOCS-176 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-176

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Drake kdrake@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@ocpdocs-previewbot
Copy link

🤖 Mon Apr 29 18:17:32 - Prow CI generated the docs preview:

https://75296--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-prerequisites.html

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 29, 2024

@kdrake20: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kdrake20
Copy link
Contributor Author

kdrake20 commented Apr 29, 2024 •
edited

Who:
@mrbojangles3, SME
@elfosardo, SME

Timestamp: April 29, 2024 2:18 PM

Summary: Hello, could you please review my PR for this Jira issue? If changes need to be made, please comment in the PR with the desired updates.

If the PR is correct, please comment /lgtm. Thank you!

Next Steps:

  • Receive approval from SME

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024 •
edited by openshift-ci bot

@kdrake20: This pull request references HCIDOCS-176 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Fixes: HCIDOCS-176

For: Version 4.12+

Doc Preview here

Signed-off-by: Katie Drake kdrake@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mrbojangles3
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@kdrake20
Copy link
Contributor Author

kdrake20 commented Apr 30, 2024 •
edited

Who:
@chadcrum
@trewest

Timestamp: April 29, 2024 2:18 PM

Summary: Hello, could one of you please review my #75296 for this Jira issue? If changes need to be made, please comment in the PR with the desired updates.

If the PR is correct, please comment /lgtm. Thank you!

Next Steps:

  • Receive approval from QE

@kdrake20
Copy link
Contributor Author

kdrake20 commented May 2, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2024
@cbippley
Copy link
Contributor

cbippley commented May 2, 2024

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 2, 2024
cbippley
cbippley reviewed May 2, 2024
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did you get QE to sign off?

@cbippley
Copy link
Contributor

cbippley commented May 2, 2024

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 2, 2024
@kdrake20
Copy link
Contributor Author

kdrake20 commented May 3, 2024

LGTM! Did you get QE to sign off?

Not yet, but I've pinged them again. I figured I'd ask for a peer review while I was waiting. Thanks!

@kdrake20
Copy link
Contributor Author

kdrake20 commented May 3, 2024 •
edited

Who:
@chadcrum, QE
@trewest, QE

Timestamp: May 3, 2024 1:11 PM

Summary: Hello, could one of you please review my #75296 for this Jira issue? If changes need to be made, please comment in the PR with the desired updates.

If the PR is correct, please comment /lgtm. Thank you!

Next Steps:

  • Receive approval from QE

@chadcrum
Copy link

chadcrum commented May 3, 2024

/lgtm

@kdrake20
Copy link
Contributor Author

kdrake20 commented May 3, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 3, 2024
@mburke5678 mburke5678 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.12 labels May 3, 2024
@mburke5678 mburke5678 added branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 3, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone May 3, 2024
@mburke5678 mburke5678 merged commit eeb7614 into openshift:main May 3, 2024
3 checks passed
@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.12

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.13

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.14

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.15

@mburke5678
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75523

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75524

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75525

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced May 3, 2024
Merged
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75526

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2024
Merged
@openshift-cherrypick-robot
Copy link

@mburke5678: new pull request created: #75527

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbippley cbippley cbippley left review comments

Assignees

@mrbojangles3 mrbojangles3

@chadcrum chadcrum

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kdrake20 @openshift-ci-robot @ocpdocs-previewbot @mrbojangles3 @cbippley @chadcrum @mburke5678 @openshift-cherrypick-robot