Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal-fix] admonitions-tables-vsphere-13 #75282

Merged

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 29, 2024

As per the weekly OCP team meeting. Reverting admonitions because of vote to format inline with Asciidoc admonition styling that renders OK on Customer Portal as against d.o.c.

Version(s):
4.13

Link to docs preview:

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 29, 2024

🤖 Mon Apr 29 15:57:29 - Prow CI generated the docs preview:
https://75282--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@dfitzmau dfitzmau changed the title admonitions-tables-vsphere-13 [internal-fix] admonitions-tables-vsphere-13 Apr 29, 2024
@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024
@dfitzmau
Copy link
Contributor Author

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024
@dfitzmau dfitzmau force-pushed the admonitions-tables-vsphere-13 branch 2 times, most recently from a7fec7b to 15c514b Compare April 29, 2024 15:48
@dfitzmau dfitzmau force-pushed the admonitions-tables-vsphere-13 branch from 15c514b to c48f7ef Compare April 29, 2024 15:50
Copy link

openshift-ci bot commented Apr 29, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024
@mburke5678 mburke5678 added peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.13 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 29, 2024
@mburke5678 mburke5678 added this to the Continuous Release milestone Apr 29, 2024
@mburke5678
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 30, 2024
@opayne1 opayne1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 30, 2024
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@opayne1 opayne1 merged commit 55f4420 into openshift:enterprise-4.13 Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.13 lgtm Indicates that a PR is ready to be merged. merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants